From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f193.google.com (mail-ot0-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5496922352291 for ; Wed, 28 Feb 2018 05:54:19 -0800 (PST) Received: by mail-ot0-f193.google.com with SMTP id f11so2254328otj.12 for ; Wed, 28 Feb 2018 06:00:26 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180228130410.GC3769@pd.tnic> References: <20180222195811.27237-1-tony.luck@intel.com> <20180228130410.GC3769@pd.tnic> From: Dan Williams Date: Wed, 28 Feb 2018 05:59:25 -0800 Message-ID: Subject: Re: [PATCH 0/5] Teach EDAC about non-volatile DIMMs and add partial support to skx_edac List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Borislav Petkov Cc: Jean Delvare , linux-nvdimm , Aristeu Rozanski , "Rafael J. Wysocki" , Qiuxu Zhuo , Linux ACPI , Tony Luck , Lv Zheng , Mauro Carvalho Chehab , Len Brown List-ID: On Wed, Feb 28, 2018 at 5:04 AM, Borislav Petkov wrote: > On Thu, Feb 22, 2018 at 11:58:06AM -0800, Tony Luck wrote: >> This series was posted as RFC and got some review back in December: >> >> https://marc.info/?l=linux-edac&m=151257213825419&w=2 >> >> It couldn't go upstream back then because I was waiting for some updates >> to the ACPICA headers for NFIT support. Those patches are complete now, >> so here is the series again. >> >> The "partial support" part is that the changes here only do the detection of >> the non-volatile DIMMs. Coming later will be another patch/series to teach >> skx_edac how to decode system addresses to NVDIMM addresses. But this part >> stands on its own and is a useful first step. >> >> Tony Luck (5): >> EDAC: Drop duplicated array of strings for memory type names >> edac: Add new memory type for non-volatile DIMMs >> acpi, nfit: Add function to look up nvdimm device and provide SMBIOS >> handle >> firmware: dmi: Add function to look up a handle and return DIMM size >> EDAC, skx_edac: Detect non-volatile DIMMs >> >> drivers/acpi/nfit/core.c | 27 ++++++++++++++++++ >> drivers/edac/Kconfig | 5 +++- >> drivers/edac/edac_mc.c | 41 +++++++++++++------------- >> drivers/edac/edac_mc_sysfs.c | 26 ++--------------- >> drivers/edac/skx_edac.c | 68 ++++++++++++++++++++++++++++++++++++++++---- >> drivers/firmware/dmi_scan.c | 31 ++++++++++++++++++++ >> include/acpi/nfit.h | 26 +++++++++++++++++ >> include/linux/dmi.h | 2 ++ >> include/linux/edac.h | 3 ++ >> 9 files changed, 178 insertions(+), 51 deletions(-) >> create mode 100644 include/acpi/nfit.h > > Series looks ok to me. > > Dan, I could route patch 3 through the EDAC tree if you'd prefer. Yes, please, and you can add: Acked-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm