From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F16652C83 for ; Thu, 28 Oct 2021 01:41:25 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id oa4so3483088pjb.2 for ; Wed, 27 Oct 2021 18:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+57OykW2c30gUJR4jUskDQk4x1gwxn9Qbm17JsREFMA=; b=GwABTqD6Tkvmyhn2eav2yJwtbW1tJceyJOpR55oElF8Cpl62Tl7fpwDRJSoK85tktg WcSZzYI1J3gqZuBvcpDIMaP3fjxWgAXp2/71GNnfMTHJUKsW82nQtl3PxcHMw5XB0BGj ol0Z6vrOct/ohRKJEQ4971tC4ghv27sixDbbqgpjArwG9QA0di/1K6lcnuWx54KE2Iv0 PlLdrGzgfAPZa89z4zZVquTUHRBE3n1XFA2eZslunyTMpQ/h+DaZ/H5bzksM/u3SBYyF eGC2TY3oTZ8dh7yBcSfW5yNsChH5J+OrCKaL/dFJg1o9GeZbeU8dYWzE/mMch4zQe8Vr Evvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+57OykW2c30gUJR4jUskDQk4x1gwxn9Qbm17JsREFMA=; b=JeliaaTYvaAkVcA9kMxK0BPZe+fCobCm/zIdYvcRDDVi3Uh46qlEG3rGOYbERfRv7s T5Oi1JsGwaY81X2ErXLSxCH4KNkW60hgc4WKjiT9fuXAvnApdKj2mE8MhuhTSI9rbZGS wwCnwjmESvJv8EfaysC0WZtyJb9T2gCSsOhc3+8PSXtp/turoNufwAKITBQHcthOHzqq EAWOw2xp7vn1cdQ2OXhZ2/HG5R5YJqS9rQFXiMHh8x5SElVP+m2VflYRRx+2owfz8hrI L+Lf4W9ap+U8VeTdd0jlbp6cdRBH+VcX3MQXW7uyPDmI/aHz6YvgBlzzh1badtVmnDC8 TWrw== X-Gm-Message-State: AOAM531e8QkJT/GC/SywofouadSxiHD3sE7craJU4kf+aQ1oZlwKoBC4 pUr4iCtCtUzKuHZwBfP1sKAFtUBGa6svi1p2cCsaUA== X-Google-Smtp-Source: ABdhPJy+l4+hDjjFqjiYrNzY24jHwGCV82yPyLMD7+lqHF6GqMdOIsbo6sHeOhaMgqSlqL4IZjgKI/J2hsCPQtYDPIA= X-Received: by 2002:a17:902:ab50:b0:13f:4c70:9322 with SMTP id ij16-20020a170902ab5000b0013f4c709322mr995386plb.89.1635385285322; Wed, 27 Oct 2021 18:41:25 -0700 (PDT) Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> In-Reply-To: <20211018044054.1779424-11-hch@lst.de> From: Dan Williams Date: Wed, 27 Oct 2021 18:41:13 -0700 Message-ID: Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper To: Christoph Hellwig , Mike Snitzer Cc: Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > Add a helper to perform the entire remapping for DAX accesses. This > helper open codes bdev_dax_pgoff given that the alignment checks have > already been done by the submitting file system and don't need to be > repeated. Again, looks good. Kind of embarrassing when the open-coded version is less LOC than using the helper. Mike, ack? > > Signed-off-by: Christoph Hellwig > --- > drivers/md/dm-stripe.c | 63 ++++++++++-------------------------------- > 1 file changed, 15 insertions(+), 48 deletions(-) > > diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c > index f084607220293..50dba3f39274c 100644 > --- a/drivers/md/dm-stripe.c > +++ b/drivers/md/dm-stripe.c > @@ -301,83 +301,50 @@ static int stripe_map(struct dm_target *ti, struct bio *bio) > } > > #if IS_ENABLED(CONFIG_FS_DAX) > -static long stripe_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, > - long nr_pages, void **kaddr, pfn_t *pfn) > +static struct dax_device *stripe_dax_pgoff(struct dm_target *ti, pgoff_t *pgoff) > { > - sector_t dev_sector, sector = pgoff * PAGE_SECTORS; > struct stripe_c *sc = ti->private; > - struct dax_device *dax_dev; > struct block_device *bdev; > + sector_t dev_sector; > uint32_t stripe; > - long ret; > > - stripe_map_sector(sc, sector, &stripe, &dev_sector); > + stripe_map_sector(sc, *pgoff * PAGE_SECTORS, &stripe, &dev_sector); > dev_sector += sc->stripe[stripe].physical_start; > - dax_dev = sc->stripe[stripe].dev->dax_dev; > bdev = sc->stripe[stripe].dev->bdev; > > - ret = bdev_dax_pgoff(bdev, dev_sector, nr_pages * PAGE_SIZE, &pgoff); > - if (ret) > - return ret; > + *pgoff = (get_start_sect(bdev) + dev_sector) >> PAGE_SECTORS_SHIFT; > + return sc->stripe[stripe].dev->dax_dev; > +} > + > +static long stripe_dax_direct_access(struct dm_target *ti, pgoff_t pgoff, > + long nr_pages, void **kaddr, pfn_t *pfn) > +{ > + struct dax_device *dax_dev = stripe_dax_pgoff(ti, &pgoff); > + > return dax_direct_access(dax_dev, pgoff, nr_pages, kaddr, pfn); > } > > static size_t stripe_dax_copy_from_iter(struct dm_target *ti, pgoff_t pgoff, > void *addr, size_t bytes, struct iov_iter *i) > { > - sector_t dev_sector, sector = pgoff * PAGE_SECTORS; > - struct stripe_c *sc = ti->private; > - struct dax_device *dax_dev; > - struct block_device *bdev; > - uint32_t stripe; > - > - stripe_map_sector(sc, sector, &stripe, &dev_sector); > - dev_sector += sc->stripe[stripe].physical_start; > - dax_dev = sc->stripe[stripe].dev->dax_dev; > - bdev = sc->stripe[stripe].dev->bdev; > + struct dax_device *dax_dev = stripe_dax_pgoff(ti, &pgoff); > > - if (bdev_dax_pgoff(bdev, dev_sector, ALIGN(bytes, PAGE_SIZE), &pgoff)) > - return 0; > return dax_copy_from_iter(dax_dev, pgoff, addr, bytes, i); > } > > static size_t stripe_dax_copy_to_iter(struct dm_target *ti, pgoff_t pgoff, > void *addr, size_t bytes, struct iov_iter *i) > { > - sector_t dev_sector, sector = pgoff * PAGE_SECTORS; > - struct stripe_c *sc = ti->private; > - struct dax_device *dax_dev; > - struct block_device *bdev; > - uint32_t stripe; > - > - stripe_map_sector(sc, sector, &stripe, &dev_sector); > - dev_sector += sc->stripe[stripe].physical_start; > - dax_dev = sc->stripe[stripe].dev->dax_dev; > - bdev = sc->stripe[stripe].dev->bdev; > + struct dax_device *dax_dev = stripe_dax_pgoff(ti, &pgoff); > > - if (bdev_dax_pgoff(bdev, dev_sector, ALIGN(bytes, PAGE_SIZE), &pgoff)) > - return 0; > return dax_copy_to_iter(dax_dev, pgoff, addr, bytes, i); > } > > static int stripe_dax_zero_page_range(struct dm_target *ti, pgoff_t pgoff, > size_t nr_pages) > { > - int ret; > - sector_t dev_sector, sector = pgoff * PAGE_SECTORS; > - struct stripe_c *sc = ti->private; > - struct dax_device *dax_dev; > - struct block_device *bdev; > - uint32_t stripe; > + struct dax_device *dax_dev = stripe_dax_pgoff(ti, &pgoff); > > - stripe_map_sector(sc, sector, &stripe, &dev_sector); > - dev_sector += sc->stripe[stripe].physical_start; > - dax_dev = sc->stripe[stripe].dev->dax_dev; > - bdev = sc->stripe[stripe].dev->bdev; > - > - ret = bdev_dax_pgoff(bdev, dev_sector, nr_pages << PAGE_SHIFT, &pgoff); > - if (ret) > - return ret; > return dax_zero_page_range(dax_dev, pgoff, nr_pages); > } > > -- > 2.30.2 >