From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F220F21A07A92 for ; Sun, 25 Nov 2018 12:12:12 -0800 (PST) Received: by mail-ot1-x341.google.com with SMTP id a11so14719183otr.10 for ; Sun, 25 Nov 2018 12:12:12 -0800 (PST) MIME-Version: 1.0 References: <20181119080056.13386-1-oohall@gmail.com> <20181119080056.13386-2-oohall@gmail.com> In-Reply-To: <20181119080056.13386-2-oohall@gmail.com> From: Dan Williams Date: Sun, 25 Nov 2018 12:12:01 -0800 Message-ID: Subject: Re: [PATCH 2/4] ndctl/namespace: Check for seed namespaces earlier List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Oliver O'Halloran Cc: linux-nvdimm List-ID: On Mon, Nov 19, 2018 at 12:11 AM Oliver O'Halloran wrote: > > When creating an fsdax or devdax namespace we need to verify that the > seed namespaces exist. This patch reworks the validation so that it's > done earlier to simplify the subsequent patches in the series. > > No functional changes. It does appear to have a functional change. do_setup_pfn() supports the case of statically allocated namespaces in NDCTL_NS_MODE_MEMORY mode. This is what one gets by default with "legacy" pmem defined as E820-type-12 memory. In that case the kernel assumes that the resulting memmap is always small enough to be allocated from DRAM and there is no need to use a dynamic pfn device. So, if I'm not mistaken, the deletion of do_setup_pfn() loses that special case handling. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm