Re: [PATCH v2 1/2] ndctl: convert namespace actions to use util_filter_params

[Dan Williams <dan.j.williams@intel.com>]

On Tue, Apr 24, 2018 at 3:52 PM, Dave Jiang <dave.jiang@intel.com> wrote:
> In preparation of moving to using util_filter_walk, moving parts of namespace
> params to util_filter_params.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  ndctl/namespace.c |  165 ++++++++++++++++++++++++++---------------------------
>  1 file changed, 82 insertions(+), 83 deletions(-)
>
> diff --git a/ndctl/namespace.c b/ndctl/namespace.c
> index fe86d826..e7173ce9 100644
> --- a/ndctl/namespace.c
> +++ b/ndctl/namespace.c
> @@ -40,21 +40,20 @@ static struct parameters {
>         bool mode_default;
>         bool align_default;
>         bool autolabel;
> -       const char *bus;
>         const char *map;
> -       const char *type;
>         const char *uuid;
>         const char *name;
>         const char *size;
>         const char *mode;
> -       const char *region;
>         const char *reconfig;
>         const char *sector_size;
>         const char *align;
> -} param = {
> +} ndns_action = {
>         .autolabel = true,
>  };
>
> +struct util_filter_params param;

Lets cut down on the thrash in this patch by calling this something
other than 'param'. I.e. all the parameters that are not being
converted to util_filter_params should not need to be touched.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm