From: Dan Williams <dan.j.williams@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Jane Chu <jane.chu@oracle.com>,
Luis Chamberlain <mcgrof@suse.com>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: Re: set_memory_uc() does not work with pmem poison handling
Date: Fri, 25 Jun 2021 16:49:33 -0700 [thread overview]
Message-ID: <CAPcyv4ixeE+fDaGxkdhV8uVA+_9OYkd086wA5pARA2HM6UZQGw@mail.gmail.com> (raw)
In-Reply-To: <ffc97a208ada4c7f8e3d3113dd323f78@intel.com>
On Fri, Jun 25, 2021 at 4:22 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> - else
> - rc = set_memory_uc(decoy_addr, 1);
> + else {
> + /*
> + * Bypass memtype checks since memory-failure has shot
> + * down mappings.
> + */
> + rc = _set_memory_uc(decoy_addr, 1);
> + }
>
> Does pmem "fix" poison addresses yet? If it does (or will) does it matter that
> you skip the memtype_reserve() call?
It does fix them via clear_mce_nospec(), but that also looks like it
should be using the _set_memory_wb() version to bypass the memory type
reservation twiddling.
That said, I don't understand why set_memory_wb(), non "_" version,
thinks it can unconditionally delete any memtype reservation that
might exist for that pfn? The set_memory_* apis seem disjoint (wrt
memtype) for a reason that eludes me.
prev parent reply other threads:[~2021-06-25 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 18:55 set_memory_uc() does not work with pmem poison handling Jane Chu
2021-06-22 0:15 ` Luis Chamberlain
2021-06-22 17:21 ` Jane Chu
2021-06-25 23:15 ` Dan Williams
2021-06-25 23:21 ` Luck, Tony
2021-06-25 23:49 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4ixeE+fDaGxkdhV8uVA+_9OYkd086wA5pARA2HM6UZQGw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jane.chu@oracle.com \
--cc=mcgrof@kernel.org \
--cc=mcgrof@suse.com \
--cc=nvdimm@lists.linux.dev \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).