nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h>
@ 2021-09-21  8:22 Christoph Hellwig
  2021-09-21  8:47 ` Naoya Horiguchi
  2021-09-21 18:26 ` Dan Williams
  0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-09-21  8:22 UTC (permalink / raw)
  To: akpm, naoya.horiguchi; +Cc: linux-mm, nvdimm

Not required at all, and having this causes a huge kernel rebuild
as soon as something in dax.h changes.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/mempolicy.h | 1 -
 mm/memory-failure.c       | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h
index 0aaf91b496e2fe..b4992a7e1abbd7 100644
--- a/include/linux/mempolicy.h
+++ b/include/linux/mempolicy.h
@@ -8,7 +8,6 @@
 
 #include <linux/sched.h>
 #include <linux/mmzone.h>
-#include <linux/dax.h>
 #include <linux/slab.h>
 #include <linux/rbtree.h>
 #include <linux/spinlock.h>
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 470400cc751363..adcd6d7b7233c9 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -39,6 +39,7 @@
 #include <linux/kernel-page-flags.h>
 #include <linux/sched/signal.h>
 #include <linux/sched/task.h>
+#include <linux/dax.h>
 #include <linux/ksm.h>
 #include <linux/rmap.h>
 #include <linux/export.h>
-- 
2.30.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h>
  2021-09-21  8:22 [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h> Christoph Hellwig
@ 2021-09-21  8:47 ` Naoya Horiguchi
  2021-09-21 18:26 ` Dan Williams
  1 sibling, 0 replies; 3+ messages in thread
From: Naoya Horiguchi @ 2021-09-21  8:47 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: akpm, naoya.horiguchi, linux-mm, nvdimm

On Tue, Sep 21, 2021 at 10:22:53AM +0200, Christoph Hellwig wrote:
> Not required at all, and having this causes a huge kernel rebuild
> as soon as something in dax.h changes.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me.

Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h>
  2021-09-21  8:22 [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h> Christoph Hellwig
  2021-09-21  8:47 ` Naoya Horiguchi
@ 2021-09-21 18:26 ` Dan Williams
  1 sibling, 0 replies; 3+ messages in thread
From: Dan Williams @ 2021-09-21 18:26 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Andrew Morton, Naoya Horiguchi, Linux MM, Linux NVDIMM

On Tue, Sep 21, 2021 at 1:23 AM Christoph Hellwig <hch@lst.de> wrote:
>
> Not required at all, and having this causes a huge kernel rebuild
> as soon as something in dax.h changes.

Looks good.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-21 18:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-21  8:22 [PATCH] mm: don't include <linux/dax.h> in <linux/mempolicy.h> Christoph Hellwig
2021-09-21  8:47 ` Naoya Horiguchi
2021-09-21 18:26 ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).