From: Dan Williams <dan.j.williams@intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Johannes Thumshirn <jthumshirn@suse.de>,
"Kani, Toshimitsu" <toshi.kani@hpe.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305!
Date: Wed, 26 Jul 2017 09:08:00 -0700 [thread overview]
Message-ID: <CAPcyv4j4ifRiS-J42p1DfOU0TjMYAyc1_==72+RPXvutyXxpMA@mail.gmail.com> (raw)
In-Reply-To: <20170726142348.GA4130@linux.intel.com>
On Wed, Jul 26, 2017 at 7:23 AM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> On Wed, Jul 26, 2017 at 06:23:08PM +0900, OGAWA Hirofumi wrote:
>> "Kani, Toshimitsu" <toshi.kani@hpe.com> writes:
>>
>> > kernel BUG at fs/buffer.c:3305!
>> > invalid opcode: 0000 [#1] SMP
>> > :
>> > Workqueue: writeback wb_workfn (flush-259:0)
>> > task: ffff8d02595b8000 task.stack: ffffa22242400000
>> > RIP: 0010:try_to_free_buffers+0xd2/0xe0
>> > RSP: 0018:ffffa22242403830 EFLAGS: 00010246
>> > RAX: 00afffc000001028 RBX: 0000000000000008 RCX: ffff8d012dcf19c0
>> > RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffffc468e3b52b80
>> > RBP: ffffa22242403858 R08: 0000000000000000 R09: 000000000002067c
>> > R10: ffff8d027ffe6000 R11: 0000000000000000 R12: 0000000000000000
>> > R13: ffff8d022fccdbe0 R14: ffffc468e3b52b80 R15: ffffa22242403ad0
>> > FS: 0000000000000000(0000) GS:ffff8d027fd40000(0000)
>>
>> The locking of this path seems to be broken. The guy familiar to
>> bdev_write_page() path will made real fix though, The following patch
>> should be explaining enough what is wrong.
>
> Is there someone in particular who is familiar with bdev_write_page() that is
> working on this fix, or does someone need to pick this up?
Another question, does ->rw_page() really buy us that much with the
pmem driver? If applications want to enjoy the lowest latency access
they can just use DAX. There's now only 4 drivers that use rw_page
since nvme dropped its usage and I'd be inclined to just rip it out.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-07-26 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:37 FIle copy to FAT FS on NVDIMM hits BUG_ON at fs/buffer.c:3305! Kani, Toshimitsu
2017-07-25 22:22 ` Ross Zwisler
2017-07-25 22:27 ` Kani, Toshimitsu
2017-07-26 8:21 ` Johannes Thumshirn
2017-07-26 9:23 ` OGAWA Hirofumi
2017-07-26 14:23 ` Ross Zwisler
2017-07-26 16:08 ` Dan Williams [this message]
2017-07-26 17:03 ` Christoph Hellwig
2017-07-26 17:11 ` Matthew Wilcox
2017-07-27 16:12 ` Kani, Toshimitsu
2017-07-27 18:03 ` Ross Zwisler
2017-07-27 18:20 ` Kani, Toshimitsu
2017-09-20 21:04 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4j4ifRiS-J42p1DfOU0TjMYAyc1_==72+RPXvutyXxpMA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jthumshirn@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).