* [PATCH] ndctl: fix input/output size for Intel firmware update DSM
@ 2018-03-22 18:26 Dave Jiang
2018-03-22 18:28 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jiang @ 2018-03-22 18:26 UTC (permalink / raw)
To: vishal.l.verma, dan.j.williams; +Cc: linux-nvdimm
The FW_START DSM should have input/out of 0/8, the code incorrectly
is passing in 4/4. This is causing failure with newer BIOS that check
the input/output parameters more strictly.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
ndctl/lib/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
index 3c4509e4..ba210e1c 100644
--- a/ndctl/lib/intel.c
+++ b/ndctl/lib/intel.c
@@ -449,8 +449,8 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_start(struct ndctl_dimm *dimm)
BUILD_ASSERT(sizeof(struct nd_intel_fw_start) == 8);
- cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE,
- sizeof(cmd->intel->start) - 4, 4);
+ cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE, 0,
+ sizeof(cmd->intel->start));
if (!cmd)
return NULL;
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ndctl: fix input/output size for Intel firmware update DSM
2018-03-22 18:26 [PATCH] ndctl: fix input/output size for Intel firmware update DSM Dave Jiang
@ 2018-03-22 18:28 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2018-03-22 18:28 UTC (permalink / raw)
To: Dave Jiang; +Cc: linux-nvdimm
On Thu, Mar 22, 2018 at 11:26 AM, Dave Jiang <dave.jiang@intel.com> wrote:
> The FW_START DSM should have input/out of 0/8, the code incorrectly
> is passing in 4/4. This is causing failure with newer BIOS that check
> the input/output parameters more strictly.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> ndctl/lib/intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
> index 3c4509e4..ba210e1c 100644
> --- a/ndctl/lib/intel.c
> +++ b/ndctl/lib/intel.c
> @@ -449,8 +449,8 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_start(struct ndctl_dimm *dimm)
>
> BUILD_ASSERT(sizeof(struct nd_intel_fw_start) == 8);
>
> - cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE,
> - sizeof(cmd->intel->start) - 4, 4);
> + cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE, 0,
> + sizeof(cmd->intel->start));
Looks good, applied.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-22 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-22 18:26 [PATCH] ndctl: fix input/output size for Intel firmware update DSM Dave Jiang
2018-03-22 18:28 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).