From: Dan Williams <dan.j.williams@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] dax: Fix use of zero page
Date: Thu, 17 May 2018 13:03:48 -0700 [thread overview]
Message-ID: <CAPcyv4jkXiNMSqxhAshhS-+cXFnVJFkVAixrjc4Hjn7xOhgMyw@mail.gmail.com> (raw)
In-Reply-To: <20180517195656.GH26718@bombadil.infradead.org>
On Thu, May 17, 2018 at 12:56 PM, Matthew Wilcox <willy@infradead.org> wrote:
> On Thu, May 17, 2018 at 12:32:07PM -0700, Dan Williams wrote:
>> On Thu, May 17, 2018 at 11:37 AM, Matthew Wilcox <willy@infradead.org> wrote:
>> >
>> > I plucked this patch from my XArray work. It seems self-contained enough
>> > that it could go into the DAX tree for merging this cycle.
>> >
>> > From 8cb56f4ba36af38814ca7b8ba030a66384e59a21 Mon Sep 17 00:00:00 2001
>> > From: Matthew Wilcox <mawilcox@microsoft.com>
>> > Date: Thu, 29 Mar 2018 22:41:18 -0400
>> > Subject: [PATCH] dax: Fix use of zero page
>> >
>> > Use my_zero_pfn instead of ZERO_PAGE, and pass the vaddr to it so it
>> > works on MIPS and s390.
>> >
>> > Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
>>
>> I'm being thick and / or lazy, what's the user visible effect of this fix?
>
> For s390 it appears to be a performance issue:
>
> Author: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Date: Mon Oct 25 16:10:07 2010 +0200
>
> [S390] zero page cache synonyms
>
> If the zero page is mapped to virtual user space addresses that differ
> only in bit 2^12 or 2^13 we get L1 cache synonyms which can affect
> performance. Follow the mips model and use multiple zero pages to avoid
> the synonyms.
>
> MIPS' use of multiple ZERO_PAGEs predates git history. Given the
> history of MIPS' caches behaving in incredibly weird ways, I'd assume
> that getting this wrong results in miniature black holes forming and/or
> the CPU calculating the largest prime number.
Unless I am missing something I think this sounds like 4.18-rc1
material with a cc: stable. Last I heard no one is really using
dccssblk + dax, and MIPS has no way to describe pmem outside of
memmap= which is only a development tool.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-05-17 20:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 18:37 [PATCH] dax: Fix use of zero page Matthew Wilcox
2018-05-17 19:24 ` Ross Zwisler
2018-05-17 19:29 ` Ross Zwisler
2018-05-17 19:57 ` Matthew Wilcox
2018-05-17 20:48 ` Ross Zwisler
2018-05-17 19:32 ` Dan Williams
2018-05-17 19:56 ` Matthew Wilcox
2018-05-17 20:03 ` Dan Williams [this message]
2018-05-17 20:48 ` Ross Zwisler
2018-08-30 16:20 Matthew Wilcox
2018-08-30 21:43 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jkXiNMSqxhAshhS-+cXFnVJFkVAixrjc4Hjn7xOhgMyw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).