From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9355B21AE30DB for ; Mon, 10 Sep 2018 07:26:57 -0700 (PDT) Received: by mail-oi0-x22b.google.com with SMTP id t68-v6so40407011oie.12 for ; Mon, 10 Sep 2018 07:26:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> From: Dan Williams Date: Mon, 10 Sep 2018 07:26:55 -0700 Message-ID: Subject: Re: open sets ext4_da_aops for DAX existing files List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Kani, Toshi" Cc: "linux-fsdevel@vger.kernel.org" , "linux-nvdimm@lists.01.org" List-ID: On Mon, Sep 10, 2018 at 7:21 AM, Kani, Toshi wrote: > On Mon, 2018-09-10 at 08:54 -0400, Jeff Moyer wrote: >> "Kani, Toshi" writes: >> >> > I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX >> > mounted ext4 files. Looking at open() path: >> >> Eek. How did you notice this? > > I tested sync path on DAX files to see if it flushes processor cache > properly. Then I noticed that it sometimes does, but sometimes doesn't. > Looking into function traces, I realized that ext4_dax_writepages() and > ext4_writepages() are called depending on their file status. Yikes, and nice find! _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm