nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
Date: Wed, 12 Sep 2018 15:02:56 -0700	[thread overview]
Message-ID: <CAPcyv4ju1v1fw2KQdq_xEToUjgqzTuVf+LPbksMgp+vUOtD_8w@mail.gmail.com> (raw)
In-Reply-To: <20180912215759.GA3000@kroah.com>

On Wed, Sep 12, 2018 at 2:57 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Sep 12, 2018 at 02:51:53PM -0700, Dan Williams wrote:
>> On Wed, Sep 12, 2018 at 12:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
>> >> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
>> >> to check_copy_size(). This is different than what copy_to_iter() does.
>> >> Also, the addr parameter passed to check_copy_size() is the source so
>> >> therefore we should be passing in "true" instead.
>> >>
>> >> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
>> >> Cc: Fan Du <fan.du@intel.com>
>> >> Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
>> >> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> >> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>> >> Cc: stable <stable@vger.kernel.org>
>> >> ---
>> >>  include/linux/uio.h |    2 +-
>> >
>> > I am not the maintainer of this file, sorry, please work with the -mm
>> > developers for this.
>>
>> Likely this is get_maintainer.pl's fault:
>>
>> $ ./scripts/get_maintainer.pl  -f include/linux/uio.h
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:USERSPACE I/O (UIO))
>> linux-kernel@vger.kernel.org (open list)
>>
>> Maybe a MAINTAINERS update like the following is warranted, because I
>> don't think -mm developers are right either, Al seems to be authority
>> on iov_iter apis:
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d870cb57c887..0018e19b4d8e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15344,13 +15344,18 @@ F:    arch/x86/um/
>>  F:     fs/hostfs/
>>  F:     fs/hppfs/
>>
>> +USERSPACE ACCESS (uaccess, copy_{to,from}_iter)
>> +M:     Alexander Viro <viro@zeniv.linux.org.uk>
>> +S:     Maintained
>> +F:     include/linux/uio*.h
>> +F:     lib/iov_iter.c
>> +
>>  USERSPACE I/O (UIO)
>>  M:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>  S:     Maintained
>>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>>  F:     Documentation/driver-api/uio-howto.rst
>>  F:     drivers/uio/
>> -F:     include/linux/uio*.h
>
> Don't drop that line, uio_driver.h is what it should just say, right?
>

Ah, yep, I missed that. Thanks.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      reply	other threads:[~2018-09-12 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05 20:31 Dave Jiang
2018-09-06 15:45 ` Dave Jiang
2018-09-12  7:48 ` Greg KH
2018-09-12 21:51   ` Dan Williams
2018-09-12 21:57     ` Greg KH
2018-09-12 22:02       ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4ju1v1fw2KQdq_xEToUjgqzTuVf+LPbksMgp+vUOtD_8w@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).