nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
@ 2018-09-05 20:31 Dave Jiang
  2018-09-06 15:45 ` Dave Jiang
  2018-09-12  7:48 ` Greg KH
  0 siblings, 2 replies; 6+ messages in thread
From: Dave Jiang @ 2018-09-05 20:31 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, linux-nvdimm

copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
to check_copy_size(). This is different than what copy_to_iter() does.
Also, the addr parameter passed to check_copy_size() is the source so
therefore we should be passing in "true" instead.

Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")

Reported-by: Fan Du <fan.du@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
---
 include/linux/uio.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/uio.h b/include/linux/uio.h
index 409c845d4cd3..422b1c01ee0d 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -172,7 +172,7 @@ size_t copy_from_iter_flushcache(void *addr, size_t bytes, struct iov_iter *i)
 static __always_inline __must_check
 size_t copy_to_iter_mcsafe(void *addr, size_t bytes, struct iov_iter *i)
 {
-	if (unlikely(!check_copy_size(addr, bytes, false)))
+	if (unlikely(!check_copy_size(addr, bytes, true)))
 		return 0;
 	else
 		return _copy_to_iter_mcsafe(addr, bytes, i);

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
  2018-09-05 20:31 [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe() Dave Jiang
@ 2018-09-06 15:45 ` Dave Jiang
  2018-09-12  7:48 ` Greg KH
  1 sibling, 0 replies; 6+ messages in thread
From: Dave Jiang @ 2018-09-06 15:45 UTC (permalink / raw)
  To: gregkh; +Cc: linux-nvdimm, linux-kernel, Wenwei Tao



On 09/05/2018 01:31 PM, Dave Jiang wrote:
> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
> to check_copy_size(). This is different than what copy_to_iter() does.
> Also, the addr parameter passed to check_copy_size() is the source so
> therefore we should be passing in "true" instead.
> 
> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
> 
> Reported-by: Fan Du <fan.du@intel.com>
Slight correction:
Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>

> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  include/linux/uio.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/uio.h b/include/linux/uio.h
> index 409c845d4cd3..422b1c01ee0d 100644
> --- a/include/linux/uio.h
> +++ b/include/linux/uio.h
> @@ -172,7 +172,7 @@ size_t copy_from_iter_flushcache(void *addr, size_t bytes, struct iov_iter *i)
>  static __always_inline __must_check
>  size_t copy_to_iter_mcsafe(void *addr, size_t bytes, struct iov_iter *i)
>  {
> -	if (unlikely(!check_copy_size(addr, bytes, false)))
> +	if (unlikely(!check_copy_size(addr, bytes, true)))
>  		return 0;
>  	else
>  		return _copy_to_iter_mcsafe(addr, bytes, i);
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
  2018-09-05 20:31 [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe() Dave Jiang
  2018-09-06 15:45 ` Dave Jiang
@ 2018-09-12  7:48 ` Greg KH
  2018-09-12 21:51   ` Dan Williams
  1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-09-12  7:48 UTC (permalink / raw)
  To: Dave Jiang; +Cc: linux-kernel, linux-nvdimm

On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
> to check_copy_size(). This is different than what copy_to_iter() does.
> Also, the addr parameter passed to check_copy_size() is the source so
> therefore we should be passing in "true" instead.
> 
> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
> Cc: Fan Du <fan.du@intel.com>
> Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> Cc: stable <stable@vger.kernel.org>
> ---
>  include/linux/uio.h |    2 +-

I am not the maintainer of this file, sorry, please work with the -mm
developers for this.

thanks,

greg k-h
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
  2018-09-12  7:48 ` Greg KH
@ 2018-09-12 21:51   ` Dan Williams
  2018-09-12 21:57     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2018-09-12 21:51 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-nvdimm, Linux Kernel Mailing List, Al Viro

On Wed, Sep 12, 2018 at 12:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
>> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
>> to check_copy_size(). This is different than what copy_to_iter() does.
>> Also, the addr parameter passed to check_copy_size() is the source so
>> therefore we should be passing in "true" instead.
>>
>> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
>> Cc: Fan Du <fan.du@intel.com>
>> Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>> Cc: stable <stable@vger.kernel.org>
>> ---
>>  include/linux/uio.h |    2 +-
>
> I am not the maintainer of this file, sorry, please work with the -mm
> developers for this.

Likely this is get_maintainer.pl's fault:

$ ./scripts/get_maintainer.pl  -f include/linux/uio.h
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:USERSPACE I/O (UIO))
linux-kernel@vger.kernel.org (open list)

Maybe a MAINTAINERS update like the following is warranted, because I
don't think -mm developers are right either, Al seems to be authority
on iov_iter apis:

diff --git a/MAINTAINERS b/MAINTAINERS
index d870cb57c887..0018e19b4d8e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15344,13 +15344,18 @@ F:    arch/x86/um/
 F:     fs/hostfs/
 F:     fs/hppfs/

+USERSPACE ACCESS (uaccess, copy_{to,from}_iter)
+M:     Alexander Viro <viro@zeniv.linux.org.uk>
+S:     Maintained
+F:     include/linux/uio*.h
+F:     lib/iov_iter.c
+
 USERSPACE I/O (UIO)
 M:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
 F:     Documentation/driver-api/uio-howto.rst
 F:     drivers/uio/
-F:     include/linux/uio*.h

 UTIL-LINUX PACKAGE
 M:     Karel Zak <kzak@redhat.com>

---

In any event, the patch in question is a trivial one liner, I feel
confident sending it along to Linus with some other pending fixes.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
  2018-09-12 21:51   ` Dan Williams
@ 2018-09-12 21:57     ` Greg KH
  2018-09-12 22:02       ` Dan Williams
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-09-12 21:57 UTC (permalink / raw)
  To: Dan Williams; +Cc: linux-nvdimm, Linux Kernel Mailing List, Al Viro

On Wed, Sep 12, 2018 at 02:51:53PM -0700, Dan Williams wrote:
> On Wed, Sep 12, 2018 at 12:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
> >> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
> >> to check_copy_size(). This is different than what copy_to_iter() does.
> >> Also, the addr parameter passed to check_copy_size() is the source so
> >> therefore we should be passing in "true" instead.
> >>
> >> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
> >> Cc: Fan Du <fan.du@intel.com>
> >> Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
> >> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> >> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> >> Cc: stable <stable@vger.kernel.org>
> >> ---
> >>  include/linux/uio.h |    2 +-
> >
> > I am not the maintainer of this file, sorry, please work with the -mm
> > developers for this.
> 
> Likely this is get_maintainer.pl's fault:
> 
> $ ./scripts/get_maintainer.pl  -f include/linux/uio.h
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:USERSPACE I/O (UIO))
> linux-kernel@vger.kernel.org (open list)
> 
> Maybe a MAINTAINERS update like the following is warranted, because I
> don't think -mm developers are right either, Al seems to be authority
> on iov_iter apis:
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d870cb57c887..0018e19b4d8e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15344,13 +15344,18 @@ F:    arch/x86/um/
>  F:     fs/hostfs/
>  F:     fs/hppfs/
> 
> +USERSPACE ACCESS (uaccess, copy_{to,from}_iter)
> +M:     Alexander Viro <viro@zeniv.linux.org.uk>
> +S:     Maintained
> +F:     include/linux/uio*.h
> +F:     lib/iov_iter.c
> +
>  USERSPACE I/O (UIO)
>  M:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>  S:     Maintained
>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>  F:     Documentation/driver-api/uio-howto.rst
>  F:     drivers/uio/
> -F:     include/linux/uio*.h

Don't drop that line, uio_driver.h is what it should just say, right?

thanks,

greg k-h
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
  2018-09-12 21:57     ` Greg KH
@ 2018-09-12 22:02       ` Dan Williams
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2018-09-12 22:02 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-nvdimm, Linux Kernel Mailing List, Al Viro

On Wed, Sep 12, 2018 at 2:57 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Sep 12, 2018 at 02:51:53PM -0700, Dan Williams wrote:
>> On Wed, Sep 12, 2018 at 12:48 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
>> >> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
>> >> to check_copy_size(). This is different than what copy_to_iter() does.
>> >> Also, the addr parameter passed to check_copy_size() is the source so
>> >> therefore we should be passing in "true" instead.
>> >>
>> >> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
>> >> Cc: Fan Du <fan.du@intel.com>
>> >> Reported-by: Wenwei Tao <wenwei.tww@alibaba-inc.com>
>> >> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> >> Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>> >> Cc: stable <stable@vger.kernel.org>
>> >> ---
>> >>  include/linux/uio.h |    2 +-
>> >
>> > I am not the maintainer of this file, sorry, please work with the -mm
>> > developers for this.
>>
>> Likely this is get_maintainer.pl's fault:
>>
>> $ ./scripts/get_maintainer.pl  -f include/linux/uio.h
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:USERSPACE I/O (UIO))
>> linux-kernel@vger.kernel.org (open list)
>>
>> Maybe a MAINTAINERS update like the following is warranted, because I
>> don't think -mm developers are right either, Al seems to be authority
>> on iov_iter apis:
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d870cb57c887..0018e19b4d8e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15344,13 +15344,18 @@ F:    arch/x86/um/
>>  F:     fs/hostfs/
>>  F:     fs/hppfs/
>>
>> +USERSPACE ACCESS (uaccess, copy_{to,from}_iter)
>> +M:     Alexander Viro <viro@zeniv.linux.org.uk>
>> +S:     Maintained
>> +F:     include/linux/uio*.h
>> +F:     lib/iov_iter.c
>> +
>>  USERSPACE I/O (UIO)
>>  M:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>  S:     Maintained
>>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
>>  F:     Documentation/driver-api/uio-howto.rst
>>  F:     drivers/uio/
>> -F:     include/linux/uio*.h
>
> Don't drop that line, uio_driver.h is what it should just say, right?
>

Ah, yep, I missed that. Thanks.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-12 22:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 20:31 [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe() Dave Jiang
2018-09-06 15:45 ` Dave Jiang
2018-09-12  7:48 ` Greg KH
2018-09-12 21:51   ` Dan Williams
2018-09-12 21:57     ` Greg KH
2018-09-12 22:02       ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).