nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: 'Dan Williams' <dan.j.williams@intel.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: ndctl read-labels default output format
Date: Tue, 10 Jul 2018 23:34:44 +0000	[thread overview]
Message-ID: <DF4PR8401MB11805E09ADFA9532FBF689FAAB5B0@DF4PR8401MB1180.NAMPRD84.PROD.OUTLOOK.COM> (raw)



> -----Original Message-----
> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Dan Williams
> Sent: Saturday, April 9, 2016 2:40 PM
> To: linux-nvdimm@lists.01.org
> Subject: [ndctl PATCH 3/4] ndctl: new 'read-labels' utility
> 
> For debug, it is useful to be able to dump the label area of a dimm.
...
> +ndctl-read-labels - read out the label area on a dimm or set of dimms
> +
> +SYNOPSIS
> +--------
> +[verse]
> +'ndctl read-labels' <nmem0> [<nmem1>..<nmemN>] [<options>]
> +
> +include::labels-description.txt[]
> +This command dumps the raw binary data in a dimm's label area to stdout or a
> +file.  In the multi-dimm case the data is concatenated.
> +
> +OPTIONS
> +-------
> +include::labels-options.txt[]
> +-o::
> +	output file
> +-j::
> +--json::
> +	parse the label data into json assuming the 'NVDIMM Namespace
> +	Specification' format.
> +

Most ndctl commands output JSON.  This one is a bit unfriendly in dumping
binary data.  Could -j be the default mode (possibly also supporting the
-u/--human option)?

Also, it prints "read %d nmems" to stderr. That doesn't mess up piping
stdout to another tool like jq, but does mess up cutting-and-pasting
the console output and feeding it to another tool.  Could that line
be dropped?  Keep the similar prints for commands that request actions
rather than print information.

---
Robert Elliott, HPE Persistent Memory


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

                 reply	other threads:[~2018-07-10 23:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF4PR8401MB11805E09ADFA9532FBF689FAAB5B0@DF4PR8401MB1180.NAMPRD84.PROD.OUTLOOK.COM \
    --to=elliott@hpe.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).