From: "qi.fuli@fujitsu.com" <qi.fuli@fujitsu.com>
To: 'Dan Williams' <dan.j.williams@intel.com>,
'Vishal Verma' <vishal.l.verma@intel.com>
Cc: "tokunaga.keiich@fujitsu.com" <tokunaga.keiich@fujitsu.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: RE: [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file
Date: Mon, 5 Nov 2018 08:05:26 +0000 [thread overview]
Message-ID: <OSAPR01MB3396D0178746BDD162F0DD15F7CA0@OSAPR01MB3396.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OS2PR01MB0836B4F845FDD0AFC3997966F7FE0@OS2PR01MB0836.jpnprd01.prod.outlook.com>
> > Hi,
> >
> > I have a future cleanup request. I've just come across, ciniparser
> > [1]. It would be great if we could drop the open coded implementation and just
> use that library.
> > We use ccan modules for other portions of ndctl.
> >
> > [1]: https://ccodearchive.net/info/ciniparser.html
>
> Hi Dan,
>
> It sounds good.
> I will study on it a bit and then make a cleanup patch.
>
> Thank you very much.
> Qi
Hi,
I have finished importing the ccan/ciniparser module and refactoring the read_config_file() in my local branch.
But thinking more about that more than one configuration file might be added into ndctl in future,
I want to add a common function parse_config_file() into ndctl/util/ to replace read_config_file().
If you agree, I will try to make a patch.
Thank you very much.
QI
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-11-05 8:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 23:33 [ndctl PATCH v13 0/5] ndctl, monitor: add ndctl monitor daemon QI Fuli
2018-07-13 23:33 ` [ndctl PATCH v13 1/5] ndctl, monitor: add a new command - monitor QI Fuli
2018-07-13 23:33 ` [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file QI Fuli
2018-10-16 0:23 ` Dan Williams
2018-10-16 4:09 ` qi.fuli
2018-11-05 8:05 ` qi.fuli [this message]
2018-07-13 23:33 ` [ndctl PATCH v13 3/5] ndctl, monitor: add the unit file of systemd for ndctl-monitor service QI Fuli
2018-07-13 23:33 ` [ndctl PATCH v13 4/5] ndctl, documentation: add man page for monitor QI Fuli
2018-07-13 23:33 ` [ndctl PATCH v13 5/5] ndctl, test: add a new unit test " QI Fuli
2018-07-19 0:42 ` [ndctl PATCH v13 0/5] ndctl, monitor: add ndctl monitor daemon Verma, Vishal L
2018-07-19 1:02 ` Qi, Fuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSAPR01MB3396D0178746BDD162F0DD15F7CA0@OSAPR01MB3396.jpnprd01.prod.outlook.com \
--to=qi.fuli@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=tokunaga.keiich@fujitsu.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).