From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa14.fujitsucc.c3s2.iphmx.com (esa14.fujitsucc.c3s2.iphmx.com [68.232.156.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8773D21B02822 for ; Mon, 5 Nov 2018 00:05:41 -0800 (PST) From: "qi.fuli@fujitsu.com" Subject: RE: [ndctl PATCH v13 2/5] ndctl, monitor: add main ndctl monitor configuration file Date: Mon, 5 Nov 2018 08:05:26 +0000 Message-ID: References: <20180713233350.7148-1-qi.fuli@jp.fujitsu.com> <20180713233350.7148-3-qi.fuli@jp.fujitsu.com> In-Reply-To: Content-Language: en-US MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: 'Dan Williams' , 'Vishal Verma' Cc: "tokunaga.keiich@fujitsu.com" , linux-nvdimm List-ID: > > Hi, > > > > I have a future cleanup request. I've just come across, ciniparser > > [1]. It would be great if we could drop the open coded implementation and just > use that library. > > We use ccan modules for other portions of ndctl. > > > > [1]: https://ccodearchive.net/info/ciniparser.html > > Hi Dan, > > It sounds good. > I will study on it a bit and then make a cleanup patch. > > Thank you very much. > Qi Hi, I have finished importing the ccan/ciniparser module and refactoring the read_config_file() in my local branch. But thinking more about that more than one configuration file might be added into ndctl in future, I want to add a common function parse_config_file() into ndctl/util/ to replace read_config_file(). If you agree, I will try to make a patch. Thank you very much. QI _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm