nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Huaisheng HS1 Ye <yehs1@lenovo.com>
To: Huaisheng Ye <yehs2007@zoho.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"snitzer@redhat.com" <snitzer@redhat.com>,
	NingTing Cheng <chengnt@lenovo.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"willy@infradead.org" <willy@infradead.org>,
	"colyli@suse.de" <colyli@suse.de>,
	"bart.vanassche@wdc.com" <bart.vanassche@wdc.com>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"jack@suse.cz" <jack@suse.cz>, "agk@redhat.com" <agk@redhat.com>,
	"keescook@chromium.org" <keescook@chromium.org>
Subject: RE: [External]  [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access()
Date: Mon, 30 Jul 2018 07:30:07 +0000	[thread overview]
Message-ID: <TY2PR03MB3343C33E4D747830A550438E922F0@TY2PR03MB3343.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <20180730071548.9172-1-yehs2007@zoho.com>

Missing one in changes log.

> From: Huaisheng Ye <yehs2007@zoho.com>
> Sent: Monday, July 30, 2018 3:16 PM
> 
> From: Huaisheng Ye <yehs1@lenovo.com>
> 
> Changes since v2 [2]:
> * Collect Martin and Mike's acks for dcssblk and dm-writecache;
> * Rebase the series of patch to v4.18-rc7.
* Collect Ross's reviewed-by for series.

> 
> Changes since v1 [1]:
> * Involve the previous patches for pfn can be NULL.
> * Reword the patch descriptions according to Christian's comment.
> * According to Ross's suggestion, replace local pointer dummy_addr
>   with NULL within md/dm-writecache for direct_access.
> 
> [1]: https://lkml.org/lkml/2018/7/24/199
> [2]: https://lkml.org/lkml/2018/7/25/581
> 
> Some functions within fs/dax, dax/super and md/dm-writecache don't
> need to get local pointer kaddr or variable pfn from direct_access.
> Assigning NULL to kaddr or pfn with ->direct_access() is more
> straightforward and simple than offering a useless local pointer or
> variable.
> 
> So all ->direct_access() need to check the validity of pointer kaddr
> and pfn for NULL assignment. If either of them is equal to NULL, that
> is to say callers may have no need for kaddr or pfn, so this series of
> patch are prepared for allowing them to pass in NULL instead of having
> to pass in a local pointer or variable that they then just throw away.
> 
> Huaisheng Ye (6):
>   libnvdimm, pmem: kaddr and pfn can be NULL to ->direct_access()
>   s390, dcssblk: kaddr and pfn can be NULL to ->direct_access()
>   tools/testing/nvdimm: kaddr and pfn can be NULL to ->direct_access()
>   dax/super: Do not request a pointer kaddr when not required
>   md/dm-writecache: Don't request pointer dummy_addr when not required
>   filesystem-dax: Do not request kaddr and pfn when not required
> 
>  drivers/dax/super.c             |  3 +--
>  drivers/md/dm-writecache.c      |  3 +--
>  drivers/nvdimm/pmem.c           |  7 +++++--
>  drivers/s390/block/dcssblk.c    |  8 +++++---
>  fs/dax.c                        | 13 ++++---------
>  tools/testing/nvdimm/pmem-dax.c | 12 ++++++++----
>  6 files changed, 24 insertions(+), 22 deletions(-)
> 
> --
> 1.8.3.1
> 

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2018-07-30  7:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  7:15 [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 2/6] s390, dcssblk: " Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 4/6] dax/super: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr " Huaisheng Ye
2018-07-30  7:15 ` [PATCH v3 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-30  7:30 ` Huaisheng HS1 Ye [this message]
2018-07-31 15:35 ` [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Dave Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY2PR03MB3343C33E4D747830A550438E922F0@TY2PR03MB3343.apcprd03.prod.outlook.com \
    --to=yehs1@lenovo.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=chengnt@lenovo.com \
    --cc=colyli@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jack@suse.cz \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=snitzer@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --cc=yehs2007@zoho.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).