From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.bemta24.messagelabs.com (mail1.bemta24.messagelabs.com [67.219.250.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC49521B02845 for ; Mon, 30 Jul 2018 00:30:37 -0700 (PDT) From: Huaisheng HS1 Ye Subject: RE: [External] [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Date: Mon, 30 Jul 2018 07:30:07 +0000 Message-ID: References: <20180730071548.9172-1-yehs2007@zoho.com> In-Reply-To: <20180730071548.9172-1-yehs2007@zoho.com> Content-Language: zh-CN MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Huaisheng Ye , "linux-nvdimm@lists.01.org" , "dan.j.williams@intel.com" Cc: "axboe@kernel.dk" , "linux-s390@vger.kernel.org" , "snitzer@redhat.com" , NingTing Cheng , "linux-fsdevel@vger.kernel.org" , "heiko.carstens@de.ibm.com" , "linux-kernel@vger.kernel.org" , "willy@infradead.org" , "colyli@suse.de" , "bart.vanassche@wdc.com" , "dm-devel@redhat.com" , "viro@zeniv.linux.org.uk" , "gregkh@linuxfoundation.org" , "schwidefsky@de.ibm.com" , "jack@suse.cz" , "agk@redhat.com" , "keescook@chromium.org" List-ID: Missing one in changes log. > From: Huaisheng Ye > Sent: Monday, July 30, 2018 3:16 PM > > From: Huaisheng Ye > > Changes since v2 [2]: > * Collect Martin and Mike's acks for dcssblk and dm-writecache; > * Rebase the series of patch to v4.18-rc7. * Collect Ross's reviewed-by for series. > > Changes since v1 [1]: > * Involve the previous patches for pfn can be NULL. > * Reword the patch descriptions according to Christian's comment. > * According to Ross's suggestion, replace local pointer dummy_addr > with NULL within md/dm-writecache for direct_access. > > [1]: https://lkml.org/lkml/2018/7/24/199 > [2]: https://lkml.org/lkml/2018/7/25/581 > > Some functions within fs/dax, dax/super and md/dm-writecache don't > need to get local pointer kaddr or variable pfn from direct_access. > Assigning NULL to kaddr or pfn with ->direct_access() is more > straightforward and simple than offering a useless local pointer or > variable. > > So all ->direct_access() need to check the validity of pointer kaddr > and pfn for NULL assignment. If either of them is equal to NULL, that > is to say callers may have no need for kaddr or pfn, so this series of > patch are prepared for allowing them to pass in NULL instead of having > to pass in a local pointer or variable that they then just throw away. > > Huaisheng Ye (6): > libnvdimm, pmem: kaddr and pfn can be NULL to ->direct_access() > s390, dcssblk: kaddr and pfn can be NULL to ->direct_access() > tools/testing/nvdimm: kaddr and pfn can be NULL to ->direct_access() > dax/super: Do not request a pointer kaddr when not required > md/dm-writecache: Don't request pointer dummy_addr when not required > filesystem-dax: Do not request kaddr and pfn when not required > > drivers/dax/super.c | 3 +-- > drivers/md/dm-writecache.c | 3 +-- > drivers/nvdimm/pmem.c | 7 +++++-- > drivers/s390/block/dcssblk.c | 8 +++++--- > fs/dax.c | 13 ++++--------- > tools/testing/nvdimm/pmem-dax.c | 12 ++++++++---- > 6 files changed, 24 insertions(+), 22 deletions(-) > > -- > 1.8.3.1 > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm