nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Huaisheng HS1 Ye <yehs1@lenovo.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	NingTing Cheng <chengnt@lenovo.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"willy@infradead.org" <willy@infradead.org>,
	"bart.vanassche@wdc.com" <bart.vanassche@wdc.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"jack@suse.cz" <jack@suse.cz>
Subject: RE: [External] Re: [PATCH 3/5] s390, dcssblk: Allow a NULL-kaddr to ->direct_access()
Date: Tue, 24 Jul 2018 14:28:23 +0000	[thread overview]
Message-ID: <TY2PR03MB3343CC5CD32DBD527DABFDE592550@TY2PR03MB3343.apcprd03.prod.outlook.com> (raw)
In-Reply-To: <814b615b-fc5d-627a-a11e-c54796b1b08d@de.ibm.com>

From: Christian Borntraeger <borntraeger@de.ibm.com>
Sent: Tuesday, July 24, 2018 7:16 PM
> >> So you are trading of a load + add (dev_info->start should be cache hot) against a
> >> compare+branch . Not sure that this is always a win.
> >
> > Hmm...the calculation process of pfn is more complicated than kaddr. I think you agree to
> check pfn but not sure kaddr, right?
> > From the logical consistency of code, I think it shall be better to give pfn and kaddr similar
> treatment.
> 
> Reading it again, its more that I do not like the patch description. It reads
> like an optimization, (and I think it is not) but it should rather read more
> like "with an upcoming change kaddr can be NULL" or so.

Thanks for suggestion, I will reword the patch description during next submission.
Does the patch itself need to be modified? If has, any suggestion is welcome.

Cheers,
Huaisheng Ye
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2018-07-24 14:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24  8:45 [PATCH 0/5] Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-24  8:45 ` [PATCH 1/5] libnvdimm, pmem: Allow a NULL-kaddr to ->direct_access() Huaisheng Ye
2018-07-24  8:45 ` [PATCH 2/5] tools/testing/nvdimm: " Huaisheng Ye
2018-07-24  8:45 ` [PATCH 3/5] s390, dcssblk: " Huaisheng Ye
2018-07-24  8:53   ` Christian Borntraeger
2018-07-24  9:46     ` [External] " Huaisheng HS1 Ye
2018-07-24 11:16       ` Christian Borntraeger
2018-07-24 14:28         ` Huaisheng HS1 Ye [this message]
2018-07-24  8:45 ` [PATCH 4/5] filesystem-dax: Do not request a pointer kaddr when not required Huaisheng Ye
2018-07-24  8:45 ` [PATCH 5/5] dax/super: " Huaisheng Ye
2018-07-24 14:50 ` [PATCH 0/5] " Ross Zwisler
2018-07-24 15:41   ` [External] " Huaisheng HS1 Ye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY2PR03MB3343CC5CD32DBD527DABFDE592550@TY2PR03MB3343.apcprd03.prod.outlook.com \
    --to=yehs1@lenovo.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chengnt@lenovo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).