From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4E1372117D76C for ; Tue, 6 Nov 2018 08:26:32 -0800 (PST) Subject: Re: [PATCH] acpi, nfit: Fix ARS overflow continuation References: <154152034315.1304656.17798869260848445154.stgit@dwillia2-desk3.amr.corp.intel.com> From: Dave Jiang Message-ID: Date: Tue, 6 Nov 2018 09:26:30 -0700 MIME-Version: 1.0 In-Reply-To: <154152034315.1304656.17798869260848445154.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams , linux-nvdimm@lists.01.org Cc: Jacek Zloch , linux-kernel@vger.kernel.org, stable@vger.kernel.org List-ID: On 11/6/18 9:05 AM, Dan Williams wrote: > When the platform BIOS is unable to report all the media error records > it requires the OS to restart the scrub at a prescribed location. The > driver detects the overflow condition, but then fails to report it to > the ARS state machine after reaping the records. Propagate -ENOSPC > correctly to continue the ARS operation. > > Cc: > Fixes: 1cf03c00e7c1 ("nfit: scrub and register regions in a workqueue") > Reported-by: Jacek Zloch > Signed-off-by: Dan Williams Reviewed-by: Dave Jiang > --- > drivers/acpi/nfit/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index f8c638f3c946..5970b8f5f768 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -2928,9 +2928,9 @@ static int acpi_nfit_query_poison(struct acpi_nfit_desc *acpi_desc) > return rc; > > if (ars_status_process_records(acpi_desc)) > - return -ENOMEM; > + dev_err(acpi_desc->dev, "Failed to process ARS records\n"); > > - return 0; > + return rc; > } > > static int ars_register(struct acpi_nfit_desc *acpi_desc, > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm > _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm