From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7726A212E1597 for ; Fri, 26 Jul 2019 16:33:19 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [ndctl PATCH v7 11/13] contrib/ndctl: fix region-id completions for daxctl Date: Fri, 26 Jul 2019 23:30:50 +0000 Message-ID: References: <20190724215741.18556-1-vishal.l.verma@intel.com> <20190724215741.18556-12-vishal.l.verma@intel.com> In-Reply-To: Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Williams, Dan J" Cc: "dave.hansen@linux.intel.com" , "pasha.tatashin@soleen.com" , "linux-nvdimm@lists.01.org" List-ID: On Thu, 2019-07-25 at 19:55 -0700, Dan Williams wrote: > On Wed, Jul 24, 2019 at 2:58 PM Vishal Verma > wrote: > > The completion helpers for daxctl assumed the region arguments for > > specifying daxctl regions were the same as ndctl regions, i.e. > > "regionX". This is not true - daxctl region arguments are a simple > > numeric 'id'. > > Oh, that's an unfortunate difference, but too late to change now I > think, good find. > > Reviewed-by: Dan Williams Yep - though I think I like --region=0 better than --region=region0, less redundancy. But agreed, probably too late to change. Thanks for reviewing these! _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm