From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-nvdimm-bounces@lists.01.org>
Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com
 [IPv6:2607:f8b0:400e:c00::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 42B1D20352141
 for <linux-nvdimm@lists.01.org>; Fri, 27 Apr 2018 01:37:04 -0700 (PDT)
Received: by mail-pf0-x235.google.com with SMTP id j5so978405pfh.2
 for <linux-nvdimm@lists.01.org>; Fri, 27 Apr 2018 01:37:04 -0700 (PDT)
Date: Fri, 27 Apr 2018 01:37:02 -0700 (PDT)
From: David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v3] dax: Change return type to vm_fault_t
In-Reply-To: <CAFqt6zY9E=XSiP5Q4N6Dh+oeVRkRf+wCBJx3XcD4MDJ=NdYG4g@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.1804270135100.68707@chino.kir.corp.google.com>
References: <20180417132842.GA30189@jordon-HP-15-Notebook-PC>
 <CAFqt6zY9E=XSiP5Q4N6Dh+oeVRkRf+wCBJx3XcD4MDJ=NdYG4g@mail.gmail.com>
MIME-Version: 1.0
List-Unsubscribe: <https://lists.01.org/mailman/options/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/linux-nvdimm/>
List-Post: <mailto:linux-nvdimm@lists.01.org>
List-Help: <mailto:linux-nvdimm-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/linux-nvdimm>,
 <mailto:linux-nvdimm-request@lists.01.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: linux-nvdimm-bounces@lists.01.org
Sender: "Linux-nvdimm" <linux-nvdimm-bounces@lists.01.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>, Randy Dunlap <rdunlap@infradead.org>, Matthew Wilcox <willy@infradead.org>, Andrew Morton <akpm@linux-foundation.org>
List-ID: <linux-nvdimm@lists.01.org>

On Fri, 27 Apr 2018, Souptick Joarder wrote:

> Hi Matthew/ Ross,
> 
> There are two changes exist in mm/huge_memory.c as part of this
> patch. vmf_insert_pfn_pmd() and vmf_insert_pfn_pud() functions are
> invoked from this patch.
> 
> Shall we put both in a single patch that it will easy to bisect in case
> we have any issue ?
> 

Please put them into a single patch, there's no reason to convert

int foo() -> vm_fault_t foo()

but leave

int bar()
{
	return foo()
}

It would be best just to convert all callers to also return vm_fault_t as 
I outlined in my response.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm