From: Shiyang Ruan <ruansy.fnst@fujitsu.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <djwong@kernel.org>, <linux-xfs@vger.kernel.org>,
<dan.j.williams@intel.com>, <david@fromorbit.com>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nvdimm@lists.linux.dev>, <rgoldwyn@suse.de>,
<viro@zeniv.linux.org.uk>, <willy@infradead.org>
Subject: Re: [PATCH v9 7/8] xfs: support CoW in fsdax mode
Date: Thu, 16 Sep 2021 16:51:48 +0800 [thread overview]
Message-ID: <dfa28f5e-cecb-65c4-23e1-a63ef646d2b0@fujitsu.com> (raw)
In-Reply-To: <20210916062357.GD13306@lst.de>
On 2021/9/16 14:23, Christoph Hellwig wrote:
> On Wed, Sep 15, 2021 at 06:45:00PM +0800, Shiyang Ruan wrote:
>> +static int
>> +xfs_dax_write_iomap_end(
>> + struct inode *inode,
>> + loff_t pos,
>> + loff_t length,
>> + ssize_t written,
>> + unsigned flags,
>> + struct iomap *iomap)
>> +{
>> + struct xfs_inode *ip = XFS_I(inode);
>> + /*
>> + * Usually we use @written to indicate whether the operation was
>> + * successful. But it is always positive or zero. The CoW needs the
>> + * actual error code from actor(). So, get it from
>> + * iomap_iter->processed.
>> + */
>> + const struct iomap_iter *iter =
>> + container_of(iomap, typeof(*iter), iomap);
>> +
>> + if (!xfs_is_cow_inode(ip))
>> + return 0;
>> +
>> + if (iter->processed <= 0) {
>> + xfs_reflink_cancel_cow_range(ip, pos, length, true);
>> + return 0;
>> + }
>> +
>> + return xfs_reflink_end_cow(ip, pos, iter->processed);
>
> Didn't we come to the conflusion last time that we don't actually
> need to poke into the iomap_iter here as the written argument is equal
> to iter->processed if it is > 0:
>
> if (iter->iomap.length && ops->iomap_end) {
> ret = ops->iomap_end(iter->inode, iter->pos, iomap_length(iter),
> iter->processed > 0 ? iter->processed : 0,
> iter->flags, &iter->iomap);
> ..
>
> So should be able to just do:
>
> static int
> xfs_dax_write_iomap_end(
> struct inode *inode,
> loff_t pos,
> loff_t length,
> ssize_t written,
> unsigned flags,
> struct iomap *iomap)
> {
> struct xfs_inode *ip = XFS_I(inode);
>
> if (!xfs_is_cow_inode(ip))
> return 0;
>
> if (!written) {
> xfs_reflink_cancel_cow_range(ip, pos, length, true);
> return 0;
> }
>
> return xfs_reflink_end_cow(ip, pos, written);
> }
>
I see. Thanks for your guidance.
--
Ruan
next prev parent reply other threads:[~2021-09-16 8:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 10:44 [PATCH v9 0/8] fsdax,xfs: Add reflink&dedupe support for fsdax Shiyang Ruan
2021-09-15 10:44 ` [PATCH v9 1/8] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2021-09-16 0:09 ` Darrick J. Wong
2021-09-16 1:36 ` Shiyang Ruan
2021-09-15 10:44 ` [PATCH v9 2/8] fsdax: Introduce dax_iomap_cow_copy() Shiyang Ruan
2021-09-15 10:44 ` [PATCH v9 3/8] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2021-09-16 14:51 ` kernel test robot
2021-09-15 10:44 ` [PATCH v9 4/8] fsdax: Convert dax_iomap_zero to iter model Shiyang Ruan
2021-09-16 0:11 ` Darrick J. Wong
2021-09-16 6:15 ` Christoph Hellwig
2021-09-15 10:44 ` [PATCH v9 5/8] fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero Shiyang Ruan
2021-09-16 6:16 ` Christoph Hellwig
2021-09-16 8:49 ` Shiyang Ruan
2021-09-16 22:55 ` Darrick J. Wong
2021-09-15 10:44 ` [PATCH v9 6/8] fsdax: Dedup file range to use a compare function Shiyang Ruan
2021-09-16 6:17 ` Christoph Hellwig
2021-09-15 10:45 ` [PATCH v9 7/8] xfs: support CoW in fsdax mode Shiyang Ruan
2021-09-16 0:22 ` Darrick J. Wong
2021-09-16 6:32 ` Christoph Hellwig
2021-09-17 15:33 ` Darrick J. Wong
2021-09-21 8:14 ` Christoph Hellwig
2021-09-16 6:23 ` Christoph Hellwig
2021-09-16 8:51 ` Shiyang Ruan [this message]
2021-09-15 10:45 ` [PATCH v9 8/8] xfs: Add dax dedupe support Shiyang Ruan
2021-09-16 0:30 ` Darrick J. Wong
2021-09-16 4:01 ` Shiyang Ruan
2021-09-16 4:18 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa28f5e-cecb-65c4-23e1-a63ef646d2b0@fujitsu.com \
--to=ruansy.fnst@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rgoldwyn@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).