From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAF81422B7 for ; Fri, 29 Mar 2024 13:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711718927; cv=none; b=fvPOZzaAKC4b8NL7YQBbtlssMqjUpZAQxFBaSkVUSGnBXS3acoml6XUGsDY0MuHfzTk+qwGmH2tRXjYRKeZ8wyyEbC9J+8dGH4WWTpWSRUSdLN9Uh/tY+dPxs/ZJ9eune4j03ex55e4a+q8Q2Bw0vgLll1H+j8Ptd1kDXa2YveM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711718927; c=relaxed/simple; bh=zlmV0sBDPPllGZWjPqa2/c1/r7nXDK5/rzJZO9Fvals=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=W84Ba1wHdh9Iiqm6xV0VbSMJmCI3yuzd5ZijwqrNEndtXjt72gQskioW1N/9Q4aiNK6MorRRR7gA3gtEHNHT6pD45YT80j430OauRFLV1kqVJpk4WRLByp9nBClrOX5nqVqUlhtkgDoHk1AXm7XW8mzqxifv1yosIQiK593WtGI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MWBrajRe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MWBrajRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711718924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9b2+syugljaMrrOP++3j3QqL3+aM8ytb7iOaLk3Q4wQ=; b=MWBrajReQhkPUVk5hgoaE7UbInLFKnhEU+piqv+x62fmbI6D9oijh5fjIEGN9nyKmrHY8w bNQ9XM25IA0a2m0DB6wG2XWuIAgwIELbvc41Ib28mm6boVpP+O7a55s0T1kaQazeNPsapx O7Un6fjWSnYT9Ely3ua5PrNSRN5BkyU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-qJ4LaF1fOwWe6yBjL5-yhw-1; Fri, 29 Mar 2024 09:28:37 -0400 X-MC-Unique: qJ4LaF1fOwWe6yBjL5-yhw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-33ed44cb765so1145150f8f.2 for ; Fri, 29 Mar 2024 06:28:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711718915; x=1712323715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9b2+syugljaMrrOP++3j3QqL3+aM8ytb7iOaLk3Q4wQ=; b=ZlcUH6We2kR/To9Al6dtrZdQY2s68DJuf2TnQpOsXVgK3TUGOKpglgUxdpk/w+lvDu CkD9dV6MUTPkM40jpsue+xV/IRUqsbO2OuHfB4HneZ9d3/Rt9sVoGDUqi5oqd30LjKXO U0Zfl7vlGzt7zGDjVPhdT1L8Y0Sdp0mzJMh7BwF5uDXaRnyeieAHB2EWqH0ujikR5scq tU+/yr9ix0juUXBUrLFbPQkWWGpOyhXpEBN9yKsjs49B/9jB/XI6NZVGtC4q9Daewd2/ xI18s0d3v6ZIX90U2Bm0ktCeBLPzBBSk80KLq0141k29nSNw52GLxpa1dHbk3Bf2ojjE EhBg== X-Forwarded-Encrypted: i=1; AJvYcCUgZOAuY8RluxPcWWIsmF7UA9KOyuwi9y10Qtl8c92f6G3zxU7PjIS0UhEY6/qiBJFUqDfBsZJo15Ar+hslj5Nnk0vHuR3U X-Gm-Message-State: AOJu0YylFDehl5yHLdC7hbFdTdd4fZCFqQ42eOqtu76y9rCgQoMcCQU+ ZesjjEhqhmTN0qMk0z6GORxGRJKhjm4AYn4d/N5t0oe/rIoZ4x8/WCaTNpK8zvamJUsDfq25qgP V6NDRUiv/9Vp/5CDB/wdugg7LTxKRjstEMXWfbnwBOc3XdEapkxNQHA== X-Received: by 2002:a05:6000:258:b0:343:3e54:6208 with SMTP id m24-20020a056000025800b003433e546208mr405089wrz.55.1711718915575; Fri, 29 Mar 2024 06:28:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0y693U6Mrafzyu7YFm6f17FVsvRLIAvGL111PeLg9URymVxfxN4rrw7+XNw571qiaGR1ycw== X-Received: by 2002:a05:6000:258:b0:343:3e54:6208 with SMTP id m24-20020a056000025800b003433e546208mr405040wrz.55.1711718915211; Fri, 29 Mar 2024 06:28:35 -0700 (PDT) Received: from sgarzare-redhat (host-87-12-25-33.business.telecomitalia.it. [87.12.25.33]) by smtp.gmail.com with ESMTPSA id e11-20020a056000194b00b00341c6b53358sm4171063wry.66.2024.03.29.06.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 06:28:34 -0700 (PDT) Date: Fri, 29 Mar 2024 14:28:27 +0100 From: Stefano Garzarella To: Krzysztof Kozlowski Cc: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Richard Weinberger , Anton Ivanov , Johannes Berg , Paolo Bonzini , Stefan Hajnoczi , Jens Axboe , Marcel Holtmann , Luiz Augusto von Dentz , Olivia Mackall , Herbert Xu , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Gonglei , "David S. Miller" , Viresh Kumar , Linus Walleij , Bartosz Golaszewski , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Jean-Philippe Brucker , Joerg Roedel , Alexander Graf , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Kalle Valo , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Pankaj Gupta , Bjorn Andersson , Mathieu Poirier , "Martin K. Petersen" , Vivek Goyal , Miklos Szeredi , Anton Yakovlev , Jaroslav Kysela , Takashi Iwai , virtualization@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, iommu@lists.linux.dev, netdev@vger.kernel.org, v9fs@lists.linux.dev, kvm@vger.kernel.org, linux-wireless@vger.kernel.org, nvdimm@lists.linux.dev, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH 01/22] virtio: store owner from modules with register_virtio_driver() Message-ID: References: <20240327-module-owner-virtio-v1-0-0feffab77d99@linaro.org> <20240327-module-owner-virtio-v1-1-0feffab77d99@linaro.org> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Fri, Mar 29, 2024 at 01:07:31PM +0100, Krzysztof Kozlowski wrote: >On 29/03/2024 12:42, Stefano Garzarella wrote: >>> }; >>> >>> -int register_virtio_driver(struct virtio_driver *driver) >>> +int __register_virtio_driver(struct virtio_driver *driver, struct module *owner) >>> { >>> /* Catch this early. */ >>> BUG_ON(driver->feature_table_size && !driver->feature_table); >>> driver->driver.bus = &virtio_bus; >>> + driver->driver.owner = owner; >>> + >> >> `.driver.name = KBUILD_MODNAME` also seems very common, should we put >> that in the macro as well? > >This is a bit different thing. Every driver is expected to set owner to >itself (THIS_MODULE), but is every driver name KBUILD_MODNAME? Nope, IIUC we have 2 exceptions: - drivers/firmware/arm_scmi/virtio.c - arch/um/drivers/virt-pci.c >Remember that this overrides whatever driver actually put there. They can call __register_virtio_driver() where we can add the `name` parameter. That said, I don't have a strong opinion, we can leave it as it is. Thanks, Stefano