From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] libnvdimm, region: Fail badblocks listing for inactive regions
Date: Fri, 28 Sep 2018 11:47:24 -0700 [thread overview]
Message-ID: <e30e885b-1b4c-59b4-d187-f33c0176c9d2@intel.com> (raw)
In-Reply-To: <153815785702.2023323.12153027860843602654.stgit@dwillia2-desk3.amr.corp.intel.com>
On 09/28/2018 11:04 AM, Dan Williams wrote:
> While experimenting with region driver loading the following backtrace
> was triggered:
>
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> [..]
> Call Trace:
> dump_stack+0x85/0xcb
> register_lock_class+0x571/0x580
> ? __lock_acquire+0x2ba/0x1310
> ? kernfs_seq_start+0x2a/0x80
> __lock_acquire+0xd4/0x1310
> ? dev_attr_show+0x1c/0x50
> ? __lock_acquire+0x2ba/0x1310
> ? kernfs_seq_start+0x2a/0x80
> ? lock_acquire+0x9e/0x1a0
> lock_acquire+0x9e/0x1a0
> ? dev_attr_show+0x1c/0x50
> badblocks_show+0x70/0x190
> ? dev_attr_show+0x1c/0x50
> dev_attr_show+0x1c/0x50
>
> This results from a missing successful call to devm_init_badblocks()
> from nd_region_probe(). Block attempts to show badblocks while the
> region is not enabled.
>
> Fixes: 6a6bef90425e ("libnvdimm: add mechanism to publish badblocks...")
> Cc: <stable@vger.kernel.org>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/nvdimm/region_devs.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/region_devs.c b/drivers/nvdimm/region_devs.c
> index fa37afcd43ff..174a418cb171 100644
> --- a/drivers/nvdimm/region_devs.c
> +++ b/drivers/nvdimm/region_devs.c
> @@ -560,10 +560,17 @@ static ssize_t region_badblocks_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct nd_region *nd_region = to_nd_region(dev);
> + ssize_t rc;
>
> - return badblocks_show(&nd_region->bb, buf, 0);
> -}
> + device_lock(dev);
> + if (dev->driver)
> + rc = badblocks_show(&nd_region->bb, buf, 0);
> + else
> + rc = -ENXIO;
> + device_unlock(dev);
>
> + return rc;
> +}
> static DEVICE_ATTR(badblocks, 0444, region_badblocks_show, NULL);
>
> static ssize_t resource_show(struct device *dev,
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-09-28 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 18:04 [PATCH] libnvdimm, region: Fail badblocks listing for inactive regions Dan Williams
2018-09-28 18:47 ` Dave Jiang [this message]
2018-10-01 12:11 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e30e885b-1b4c-59b4-d187-f33c0176c9d2@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).