From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B268FC433DF for ; Fri, 9 Oct 2020 23:04:31 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C84B222EB for ; Fri, 9 Oct 2020 23:04:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="lcFP6HW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C84B222EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5D87A159FA7FD; Fri, 9 Oct 2020 16:04:30 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=vishal.l.verma@intel.com; receiver= Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C063B159FA7FA for ; Fri, 9 Oct 2020 16:04:27 -0700 (PDT) IronPort-SDR: pFE+iLchbEvagtSJWFbbOWPlEy2qapDBE1+h1CZD3xbOATi4LQjLtlw2x/W3qti8qe16rrn7tf l3SG+LxXSP7w== X-IronPort-AV: E=McAfee;i="6000,8403,9769"; a="182995043" X-IronPort-AV: E=Sophos;i="5.77,356,1596524400"; d="scan'208";a="182995043" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 16:04:25 -0700 IronPort-SDR: YbViz0Rje3d3kiB9PonF9i5zJYNg+KbWFqhiwc8eGIUpUn03tf2pIlrixLoRNYftuc9AU5arqW FM5VB82tUAJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,356,1596524400"; d="scan'208";a="344034052" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 09 Oct 2020 16:04:25 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 16:04:25 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 16:04:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 16:04:24 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 16:04:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWQLhIYXwimuofiPwvDg00g9157/mKcguewSiDDwCPnlyoAFpwsuvj3jTuFH2/y3W0WvAcZFtUC6BzBsWRTALBjZr1sJGNrOG/QiXOb/9OMr1Ytbn+QsjyMbuYtw0p55NyZRFCB/iLYvKWbr/gkrH4vMZZez32YgiXFfgkIQKZMZ9VDXhndFaedCjacJO6v5kpKgpjny0RwqKxkaEO9EHE/k42kyTiexmIbh4haL2LzHdGvE9Aaa5Ap5FbTMNqSHLk3zl+WbN2+uXCksAf4F/iN5dy8EBq1nSEBiHP15KKKz+sBoWK+x17mTRv3Su++Nr58EVrYRFl6K3icGfNml5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjPOHc07o0iRFEhlOZ60lNAPJsUy75JPpsZucZMNz8o=; b=Z7Q8UXYBTD3Z9w2heFfsRoKWZINq5vYp4c6cwi3ZRghuTKc4Gq7vfsHgoAKLGJkZNkCMvDaxBIaBw857GGLZVcwP1BW/ifLmjiTK/DUTvGGNvWsI00KS2oqcb9xO6lAFnZiv/KO9u0SbhNUmhHpphGfsnFv7GlTrr0couAy/QTHscvuPhWbidOgmDpjAJltCt27Iv9xRC7i3vbx5pLLdLTLrrjt922PPZVX50B8NXLxWpl7XkAqQG6a5a4CqxU3LnjK+44Ne/RxFc/zCyk6S6Wl96jEN+wjVwFOpYKptVAd4HiGH2meFbG20mcYgIRrr0TEEKWqcmILgiensscGbkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjPOHc07o0iRFEhlOZ60lNAPJsUy75JPpsZucZMNz8o=; b=lcFP6HW9TBrrRMhk+zYUKFaSHlf02OfC+f7xudQFjptACYyYi+2d4JD6h3ZQB5eqeBc9qnWsRweCUYrGaD2Cz82MO4Nc+BTE67PlmftDgmXvpfi82waG3rGUQNobaHN4sw1pjIZ8rZsFAGFW3pvYf19+R+aRhqXPmywcqsdRN1Y= Received: from BYAPR11MB3448.namprd11.prod.outlook.com (2603:10b6:a03:76::21) by BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Fri, 9 Oct 2020 23:04:22 +0000 Received: from BYAPR11MB3448.namprd11.prod.outlook.com ([fe80::ecd4:8f8f:fa3d:f63d]) by BYAPR11MB3448.namprd11.prod.outlook.com ([fe80::ecd4:8f8f:fa3d:f63d%7]) with mapi id 15.20.3455.028; Fri, 9 Oct 2020 23:04:22 +0000 From: "Verma, Vishal L" To: "willy@infradead.org" Subject: Re: [PATCH 0/4] Remove nrexceptional tracking Thread-Topic: [PATCH 0/4] Remove nrexceptional tracking Thread-Index: AQHWanrcgiyE+gZ1T06GDixOiuOZv6kr8b+AgAALYACAYoGWgIABzPEA Date: Fri, 9 Oct 2020 23:04:22 +0000 Message-ID: References: <20200804161755.10100-1-willy@infradead.org> <898e058f12c7340703804ed9d05df5ead9ecb50d.camel@intel.com> <20201008193301.GN20115@casper.infradead.org> In-Reply-To: <20201008193301.GN20115@casper.infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5 (3.36.5-1.fc32) authentication-results: infradead.org; dkim=none (message not signed) header.d=none;infradead.org; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.55.43] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14fbba86-2c66-4d60-07d1-08d86ca7a93b x-ms-traffictypediagnostic: BY5PR11MB3910: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: riVmwcMfP9n6zT7akDWmsXci/WYtfu/lEosNZ8couF/IjZjuUAwSvczh8K0g1cJfuPnMz9p2ZuBvx2XJi2lFb8HEIxKO2zlRQ3oJL03yLcAIFWTPO8c27OVUfZYqcStx8PACcmJc5vNI+ZpIe++iDN3U+HLaDwVLOtlHTVSY0JyQIVoQ31NoMVUgeKNywldJu+uvb6wSZnyYAeZosnZ9ug8mCIL0wIAMd8h88uyS0mQCj+44uzzD/XmHkGp4T3F7isRdz4qvQUWuMMoajl5rcgMPoEjYckvlLLmp+8P8t5Pc3ykGOSU+T76wW4YlwTfj2dC1RI3SKADc+6UIj3fBL5E6uKTG3QvqzjZcaGBnxgdP74rWuuZaixAaID0/TE57KheaCrC+PpTDVHuLVFWa/Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3448.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(366004)(39860400002)(396003)(376002)(76116006)(6916009)(4326008)(2616005)(186003)(966005)(8676002)(83380400001)(478600001)(6486002)(316002)(26005)(54906003)(8936002)(71200400001)(66446008)(66946007)(86362001)(66476007)(64756008)(6506007)(36756003)(2906002)(66556008)(83080400001)(5660300002)(6512007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: rgiTHAZIMEjzYRJGQYdodU+CWLuaV6odbDcDrGHKeG+P11MvCBM8JEoKm376TJE6n80dUZ4L4ddqw6E+5GtCsPVkIUrEv1fmRAU+FnJecGSmU0uNaXXnGt7/1oI+ZqCdk4K+HKjGV+sbBV/x3F0TZMI0jd89Rj8r+FKZuDJCOz3EkgHSAzVPVSmcaqHs3A1Lmq9igg70nrNy3KGgbkAeZh4N0xCSXF/9r56oF5M7QqkcZQK9A3GLhJFAXVCetY32rbJSlkmIOeWTAcDYFyMJGObb35UGT0Yrq8ajWWYEazkEqtEha/Cx6qHbVxpkC2Df54jO6128we2Rfxrtxy8EOUUuWpEkVO/gMZOffZfNDhNh8Epwi3Enk/DWT7J+bveg9xqpbUX75ot6JafJ9/B1BwxwPlEjX7/k/aY6wNIn6f3ru42LttemWHGrgIjrPwyCQeIGwef3bBgL8DJwjb8ipPKepx3wGsY3M+WX6IcFvAAGC+a6Bj4/IAgGFZW/4dxK86lZBsLE8maNDAV/G43nrrUtlE/CLRLUyuzfYjSr21flbI1Z7PU9qzBhnWOX66BjRwNfqh8SFqWSSynwDvMez6wpBxRYfutbx09pViDfrER8gnCrybxLcfZGLTmzbAIXUEJFeuCS7vcyWjNJTA/x4Q== x-ms-exchange-transport-forked: True Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3448.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14fbba86-2c66-4d60-07d1-08d86ca7a93b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 23:04:22.5992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dyO1wJ5WjwXHUOwdbAUUvRSLXjlM0q6hykuin4pibwRMjPRfpsFpsD6T0c8Md51XK5E29dU8av5Fg4a8j/jGuhPbgop5rxe2hPLlLuqCZLQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3910 X-OriginatorOrg: intel.com Message-ID-Hash: 7BHFJOHNUTREKK5IWDR57LMAXPBI7Q2T X-Message-ID-Hash: 7BHFJOHNUTREKK5IWDR57LMAXPBI7Q2T X-MailFrom: vishal.l.verma@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "linux-mm@kvack.org" , "linux-nvdimm@lists.01.org" , "linux-fsdevel@vger.kernel.org" X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, 2020-10-08 at 20:33 +0100, Matthew Wilcox wrote: > On Thu, Aug 06, 2020 at 08:16:02PM +0000, Verma, Vishal L wrote: > > On Thu, 2020-08-06 at 19:44 +0000, Verma, Vishal L wrote: > > > > I'm running xfstests on this patchset right now. If one of the DAX > > > > people could try it out, that'd be fantastic. > > > > > > > > Matthew Wilcox (Oracle) (4): > > > > mm: Introduce and use page_cache_empty > > > > mm: Stop accounting shadow entries > > > > dax: Account DAX entries as nrpages > > > > mm: Remove nrexceptional from inode > > > > > > Hi Matthew, > > > > > > I applied these on top of 5.8 and ran them through the nvdimm unit test > > > suite, and saw some test failures. The first failing test signature is: > > > > > > + umount test_dax_mnt > > > ./dax-ext4.sh: line 62: 15749 Segmentation fault umount $MNT > > > FAIL dax-ext4.sh (exit status: 139) > > Thanks. Fixed: > > +++ b/fs/dax.c > @@ -644,7 +644,7 @@ static int __dax_invalidate_entry(struct address_space *mapping, > goto out; > dax_disassociate_entry(entry, mapping, trunc); > xas_store(&xas, NULL); > - mapping->nrpages -= dax_entry_order(entry); > + mapping->nrpages -= 1UL << dax_entry_order(entry); > ret = 1; > out: > put_unlocked_entry(&xas, entry); > > Updated git tree at > https://git.infradead.org/users/willy/pagecache.git/ I ran this tree through the unit tests, and everything passes. (Well, while the tests passed, this tree as-is did have an RCU warning splat. I rebased to v5.9-rc8 and that was fine). Feel free to add: Tested-by: Vishal Verma _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org