nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Jiang, Dave" <dave.jiang@intel.com>
To: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: [GIT PULL]: libnvdimm updates for 4.19-rc1 v2 [2/2]
Date: Wed, 22 Aug 2018 20:22:41 +0000	[thread overview]
Message-ID: <e8622920d68c008edf72bcd93a8716fc59c2f55d.camel@intel.com> (raw)

Hi Linus,

Please pull to receive the libnvdimm dax-memory-failure series for v4.19-rc1. I have removed the
offending ilog2() call and fixed up the patch accordingly.

As Dan mentioned, the justification for pushing this sooner rather than later is to
start the pipeline to the distros since enterprise in-memory-database
developers reported this gap in the kernel memory error handling
compared to the DRAM / page cache case.

I'm including Dan's original cover for the series for context:
"
As it stands, memory_failure() gets thoroughly confused by dev_pagemap
backed mappings. The recovery code has specific enabling for several
possible page states and needs new enabling to handle poison in dax
mappings.

In order to support reliable reverse mapping of user space addresses:

1/ Add new locking in the memory_failure() rmap path to prevent races
that would typically be handled by the page lock.

2/ Since dev_pagemap pages are hidden from the page allocator and the
"compound page" accounting machinery, add a mechanism to determine the
size of the mapping that encompasses a given poisoned pfn.

3/ Given pmem errors can be repaired, change the speculatively accessed
poison protection, mce_unmap_kpfn(), to be reversible and otherwise
allow ongoing access from the kernel.

A side effect of this enabling is that MADV_HWPOISON becomes usable for
dax mappings, however the primary motivation is to allow the system to
survive userspace consumption of hardware-poison via dax. Specifically
the current behavior is:

    mce: Uncorrected hardware memory error in user-access at af34214200
    {1}[Hardware Error]: It has been corrected by h/w and requires no further action
    mce: [Hardware Error]: Machine check events logged
    {1}[Hardware Error]: event severity: corrected
    Memory failure: 0xaf34214: reserved kernel page still referenced by 1 users
    [..]
    Memory failure: 0xaf34214: recovery action for reserved kernel page: Failed
    mce: Memory error not recovered
    <reboot>

...and with these changes:

    Injecting memory failure for pfn 0x20cb00 at process virtual address 0x7f763dd00000
    Memory failure: 0x20cb00: Killing dax-pmd:5421 due to hardware memory corruption
    Memory failure: 0x20cb00: recovery action for dax page: Recovered

Given all the cross dependencies I propose taking this through
nvdimm.git with acks from Naoya, x86/core, x86/RAS, and of course dax
folks.
"

I hope you will consider pulling the patch series. Thank you!

The following changes since commit 021c91791a5e7e85c567452f1be3e4c2c6cb6063:

  Linux 4.18-rc3 (2018-07-01 16:04:53 -0700)

are available in the Git repository at:

  git@gitolite.kernel.org:pub/scm/linux/kernel/git/nvdimm/nvdimm.git tags/libnvdimm-for-4.19_dax-memory-failure

for you to fetch changes up to c953cc987ab87d180e1d5de2f1c217abe33aac77:

  libnvdimm, pmem: Restore page attributes when clearing errors (2018-08-20 09:22:45 -0700)

----------------------------------------------------------------
libnvdimm-for-4.19_dax-memory-failure

* memory_failure() gets confused by dev_pagemap backed mappings. The
  recovery code has specific enabling for several possible page states
  that needs new enabling to handle poison in dax mappings. Teach
  memory_failure() about ZONE_DEVICE pages.

----------------------------------------------------------------
Dan Williams (13):
      device-dax: Convert to vmf_insert_mixed and vm_fault_t
      device-dax: Enable page_mapping()
      device-dax: Set page->index
      filesystem-dax: Set page->index
      mm, madvise_inject_error: Disable MADV_SOFT_OFFLINE for ZONE_DEVICE pages
      mm, dev_pagemap: Do not clear ->mapping on final put
      mm, madvise_inject_error: Let memory_failure() optionally take a page reference
      mm, memory_failure: Collect mapping size in collect_procs()
      filesystem-dax: Introduce dax_lock_mapping_entry()
      mm, memory_failure: Teach memory_failure() about dev_pagemap pages
      x86/mm/pat: Prepare {reserve, free}_memtype() for "decoy" addresses
      x86/memory_failure: Introduce {set, clear}_mce_nospec()
      libnvdimm, pmem: Restore page attributes when clearing errors

 arch/x86/include/asm/set_memory.h         |  42 ++++++
 arch/x86/kernel/cpu/mcheck/mce-internal.h |  15 ---
 arch/x86/kernel/cpu/mcheck/mce.c          |  38 +-----
 arch/x86/mm/pat.c                         |  16 +++
 drivers/dax/device.c                      |  75 +++++++----
 drivers/nvdimm/pmem.c                     |  26 ++++
 drivers/nvdimm/pmem.h                     |  13 ++
 fs/dax.c                                  | 125 ++++++++++++++++--
 include/linux/dax.h                       |  13 ++
 include/linux/huge_mm.h                   |   5 +-
 include/linux/mm.h                        |   1 +
 include/linux/set_memory.h                |  14 ++
 kernel/memremap.c                         |   1 -
 mm/hmm.c                                  |   2 +
 mm/huge_memory.c                          |   4 +-
 mm/madvise.c                              |  16 ++-
 mm/memory-failure.c                       | 210 ++++++++++++++++++++++++------
 17 files changed, 481 insertions(+), 135 deletions(-)
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

             reply	other threads:[~2018-08-22 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 20:22 Jiang, Dave [this message]
2018-08-24 22:08 ` [GIT PULL]: libnvdimm updates for 4.19-rc1 v2 [2/2] Dan Williams
2018-08-26  1:32 ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8622920d68c008edf72bcd93a8716fc59c2f55d.camel@intel.com \
    --to=dave.jiang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).