From: Jeff Moyer <jmoyer@redhat.com>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc: linux-nvdimm@lists.01.org, linfeilong <linfeilong@huawei.com>
Subject: Re: [ndctl PATCH 3/8] libdaxctl: fix memory leakage in add_dax_region()
Date: Fri, 20 Nov 2020 11:33:45 -0500 [thread overview]
Message-ID: <x49v9e0m1hy.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <7ae72048-0c26-9da2-41a9-c1b63a8db117@huawei.com> (Zhiqiang Liu's message of "Fri, 6 Nov 2020 17:25:32 +0800")
Zhiqiang Liu <liuzhiqiang26@huawei.com> writes:
> In add_dax_region(), region->devname is allocated by
> calling strdup(), which may return NULL. So, we need
> to check whether region->devname is NULL, and free
> region->devname in err_read tag.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
> daxctl/lib/libdaxctl.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/daxctl/lib/libdaxctl.c b/daxctl/lib/libdaxctl.c
> index ee4a069..d841b78 100644
> --- a/daxctl/lib/libdaxctl.c
> +++ b/daxctl/lib/libdaxctl.c
> @@ -287,6 +287,8 @@ static struct daxctl_region *add_dax_region(void *parent, int id,
> region->refcount = 1;
> list_head_init(®ion->devices);
> region->devname = strdup(devpath_to_devname(base));
> + if (!region->devname)
> + goto err_read;
>
> sprintf(path, "%s/%s/size", base, attrs);
> if (sysfs_read_attr(ctx, path, buf) == 0)
> @@ -314,6 +316,7 @@ static struct daxctl_region *add_dax_region(void *parent, int id,
> err_read:
> free(region->region_buf);
> free(region->region_path);
> + free(region->devname);
> free(region);
> err_region:
> free(path);
Acked-by: Jeff Moyer <jmoyer@redhat.com>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-11-20 16:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 9:23 [ndctl PATCH 0/8] fix serverl issues reported by Coverity Zhiqiang Liu
2020-11-06 9:24 ` [ndctl PATCH 1/8] namespace: check whether pfn|dax|btt is NULL in setup_namespace Zhiqiang Liu
2020-11-20 16:29 ` Jeff Moyer
2020-11-06 9:25 ` [ndctl PATCH 2/8] lib/libndctl: fix memory leakage problem in add_bus Zhiqiang Liu
2020-11-20 16:31 ` Jeff Moyer
2020-11-06 9:25 ` [ndctl PATCH 3/8] libdaxctl: fix memory leakage in add_dax_region() Zhiqiang Liu
2020-11-20 16:33 ` Jeff Moyer [this message]
2020-11-06 9:26 ` [ndctl PATCH 4/8] dimm: fix potential fd leakage in dimm_action() Zhiqiang Liu
2020-11-20 16:36 ` Jeff Moyer
2020-11-06 9:26 ` [ndctl PATCH 5/8] util/help: check whether strdup returns NULL in exec_man_konqueror Zhiqiang Liu
2020-11-06 9:27 ` [ndctl PATCH 6/8] lib/inject: check whether cmd is created successfully Zhiqiang Liu
2020-12-17 3:33 ` Verma, Vishal L
2020-12-17 6:19 ` Zhiqiang Liu
2020-11-06 9:27 ` [ndctl PATCH 7/8] Check whether ndctl_btt_get_namespace returns NULL in callers Zhiqiang Liu
2020-11-06 9:28 ` [ndctl PATCH 8/8] Check whether seed is NULL in validate_namespace_options Zhiqiang Liu
2020-11-10 10:58 ` [ndctl PATCH 0/8] fix serverl issues reported by Coverity Zhiqiang Liu
2020-11-20 2:45 ` Zhiqiang Liu
2020-11-20 2:47 ` Verma, Vishal L
2020-11-20 3:01 ` Zhiqiang Liu
2020-11-20 16:45 ` Jeff Moyer
2020-11-23 0:47 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49v9e0m1hy.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=linfeilong@huawei.com \
--cc=linux-nvdimm@lists.01.org \
--cc=liuzhiqiang26@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).