All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Yang Zhao <yang.zhao@skyboxlabs.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] git-p4: python 3 compatability
Date: Thu, 28 Nov 2019 13:54:47 +0100 (CET)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.1911281352130.31080@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20191128012807.3103-1-yang.zhao@skyboxlabs.com>

Hi,

On Wed, 27 Nov 2019, Yang Zhao wrote:

> This patchset the necessary changes to have git-p4 run under python 3.
>
> I'm submitting this as an RFC as the changes are not exhaustive. I do not have
> p4d available, and therefore cannot run the tests locally. I have made
> best-effort attempts to test the changes against a repo I do have read access to.

How about opening a PR at https://github.com/git/git? This will run our
Travis and Azure Pipelines builds, and I am sure that you can add a
debug-only patch to force-use Python3 on the Perforce tests (and if I were
you, I would also restrict the run to those tests by editing `.travis.yml`
and `azure-pipelines.yml`, both of which files should be easy enough to
understand without additional documentation).

Ciao,
Johannes

      parent reply	other threads:[~2019-11-28 12:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  1:28 [RFC PATCH 0/4] git-p4: python 3 compatability Yang Zhao
2019-11-28  1:28 ` [RFC PATCH 1/4] git-p4: decode response from p4 to str for python3 Yang Zhao
2019-11-28  1:28 ` [RFC PATCH 2/4] git-p4: properly encode/decode communication with git for python 3 Yang Zhao
2019-11-28  1:28 ` [RFC PATCH 3/4] git-p4: open .gitp4-usercache.txt in text mode Yang Zhao
2019-11-28  1:28 ` [RFC PATCH 4/4] git-p4: use utf-8 encoding for file paths throughout Yang Zhao
2019-11-28  2:57   ` Elijah Newren
2019-11-28 12:54 ` Johannes Schindelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.QRO.7.76.6.1911281352130.31080@tvgsbejvaqbjf.bet \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=yang.zhao@skyboxlabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.