From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v2 0/3] Work around flakiness in t5500.43
Date: Mon, 26 Oct 2020 17:04:10 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2010261702410.56@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20201023085021.GF4012156@coredump.intra.peff.net>
Hi,
On Fri, 23 Oct 2020, Jeff King wrote:
> On Mon, Oct 19, 2020 at 07:35:39PM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > Changes since v1:
> >
> > * Instead of papering over the underlying cause, the patch was completely
> > changed to actually fix the bug and add a proper regression test for it
> > (originally, I wanted to act according to the common notion that good
> > programmers are lazy, oh my, see how well that worked out for me).
>
> Thanks for fixing this. Your explanation looks thorough and the code
> looks correct. Definitely patches 1 and 2 look good to me. I left a few
> comments on patch 3.
Thank you.
After thinking about this for several days, I will drop patch 3/3 because
it is unclear to me how to implement what you suggested without reverting
the intention of Jonathan's patch that made `pkt-line` depend on
`sideband` instead of the other way round.
Ciao,
Dscho
next prev parent reply other threads:[~2020-10-26 16:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:45 [PATCH] t5500.43: make the check a bit more robust Johannes Schindelin via GitGitGadget
2020-10-13 17:53 ` Junio C Hamano
2020-10-13 18:55 ` Jeff King
2020-10-13 19:07 ` Junio C Hamano
2020-10-13 19:09 ` Jeff King
2020-10-17 3:31 ` Johannes Schindelin
2020-10-17 2:34 ` Johannes Schindelin
2020-10-19 19:35 ` [PATCH v2 0/3] Work around flakiness in t5500.43 Johannes Schindelin via GitGitGadget
2020-10-19 19:35 ` [PATCH v2 1/3] sideband: avoid reporting incomplete sideband messages Johannes Schindelin via GitGitGadget
2020-10-20 20:33 ` Junio C Hamano
2020-10-20 20:48 ` Johannes Schindelin
2020-10-20 21:33 ` Junio C Hamano
2020-10-19 19:35 ` [PATCH v2 2/3] sideband: report unhandled incomplete sideband messages as bugs Johannes Schindelin via GitGitGadget
2020-10-19 19:35 ` [PATCH v2 3/3] sideband: add defense against packets missing a band designator Johannes Schindelin via GitGitGadget
2020-10-20 20:36 ` Junio C Hamano
2020-10-23 8:34 ` Jeff King
2020-10-23 14:44 ` Junio C Hamano
2020-10-23 8:48 ` Jeff King
2020-10-23 5:36 ` Johannes Schindelin
2020-10-23 8:50 ` [PATCH v2 0/3] Work around flakiness in t5500.43 Jeff King
2020-10-26 16:04 ` Johannes Schindelin [this message]
2020-10-26 16:09 ` [PATCH v3 0/2] " Johannes Schindelin via GitGitGadget
2020-10-26 16:09 ` [PATCH v3 1/2] sideband: avoid reporting incomplete sideband messages Johannes Schindelin via GitGitGadget
2020-10-26 16:09 ` [PATCH v3 2/2] sideband: report unhandled incomplete sideband messages as bugs Johannes Schindelin via GitGitGadget
2020-10-26 18:33 ` [PATCH v3 0/2] Work around flakiness in t5500.43 Junio C Hamano
2020-10-27 6:52 ` [PATCH] sideband: diagnose more incoming packet anomalies Jeff King
2020-10-27 7:12 ` Jeff King
2020-10-27 18:56 ` Junio C Hamano
2020-10-27 20:42 ` Jeff King
2020-10-27 21:38 ` Junio C Hamano
2020-10-28 9:33 ` Jeff King
2020-10-27 7:13 ` Jeff King
2020-10-27 19:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2010261702410.56@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@google.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.