Re: [PATCH v2] ci: use upload-artifacts v1 for dockerized jobs

From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] ci: use upload-artifacts v1 for dockerized jobs
Date: Sun, 15 Aug 2021 00:17:57 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.QRO.7.76.6.2108150013510.59@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <20210813091349.88574-1-carenas@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]

Hi Carlo,

On Fri, 13 Aug 2021, Carlo Marcelo Arenas Belón wrote:

> e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,
> 2021-06-23) changed all calls to that action from v1 to v2, but there
> is still an open bug[1] that affects all nodejs actions and prevents
> its use in 32-bit linux (as used by the Linux32 container)
>
> move all dockerized jobs to use v1 that was built in C# and therefore
> doesn't have this problem, which will otherwise manifest with confusing
> messages like:
>
>   /usr/bin/docker exec  0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c "cat /etc/*release | grep ^ID"
>   OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown

ACK!

This seems to be the same issue that didn't let us upgrade to
actions/checkout@v2 in the `dockerized` matrix (but of course I did not
notice the `upload-artifact` issue because the test suite did not fail
when I was working on e9f79acb28).

Thank you,
Dscho

>
> [1] https://github.com/actions/runner/issues/1011
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> v2:
> * dropped unrelated chunk and better grammar as suggested by Junio
>
>  .github/workflows/main.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 47876a4f02..68596f2592 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -271,7 +271,7 @@ jobs:
>        if: failure()
>      - name: Upload failed tests' directories
>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> -      uses: actions/upload-artifact@v2
> +      uses: actions/upload-artifact@v1
>        with:
>          name: failed-tests-${{matrix.vector.jobname}}
>          path: ${{env.FAILED_TEST_ARTIFACTS}}
> --
> 2.33.0.rc1.379.g2890ef5eb6
>
>