From: Jiri Kosina <jikos@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Gleixner <tglx@linutronix.de>, Pavel Machek <pavel@ucw.cz>,
Josh Poimboeuf <jpoimboe@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
stable@vger.kernel.org,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
Tyler Hicks <tyhicks@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpu/SMT: fix x86 link error without CONFIG_SYSFS
Date: Tue, 10 Dec 2019 21:12:57 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.1912102111480.4603@cbobk.fhfr.pm> (raw)
In-Reply-To: <20191210195614.786555-1-arnd@arndb.de>
On Tue, 10 Dec 2019, Arnd Bergmann wrote:
> When CONFIG_SYSFS is disabled, but CONFIG_HOTPLUG_SMT is enabled,
> the kernel fails to link:
I wonder where such kernels are running ... or I rather don't :)
> arch/x86/power/cpu.o: In function `hibernate_resume_nonboot_cpu_disable':
> (.text+0x38d): undefined reference to `cpuhp_smt_enable'
> arch/x86/power/hibernate.o: In function `arch_resume_nosmt':
> hibernate.c:(.text+0x291): undefined reference to `cpuhp_smt_enable'
> hibernate.c:(.text+0x29c): undefined reference to `cpuhp_smt_disable'
>
> Move the exported functions out of the #ifdef section into its
> own with the correct conditions.
>
> The patch that caused this is marked for stable backports, so
> this one may need to be backported as well.
>
> Fixes: ec527c318036 ("x86/power: Fix 'nosmt' vs hibernation triple fault during resume")
Reviewed-by: Jiri Kosina <jkosina@suse.cz>
Thanks for fixing my oversight.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-12-10 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 19:56 [PATCH] cpu/SMT: fix x86 link error without CONFIG_SYSFS Arnd Bergmann
2019-12-10 20:12 ` Jiri Kosina [this message]
2019-12-20 22:01 ` Jiri Kosina
2020-01-09 16:36 ` [tip: smp/urgent] cpu/SMT: Fix " tip-bot2 for Arnd Bergmann
[not found] ` <20200114130955.2EAC824685@mail.kernel.org>
2020-01-14 13:25 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1912102111480.4603@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=arnd@arndb.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tyhicks@canonical.com \
--cc=valentin.schneider@arm.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.