From: Jiri Kosina <jikos@kernel.org>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Makefile: disallow data races on gcc-10 as well
Date: Tue, 17 Mar 2020 02:41:21 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2003170240410.19500@cbobk.fhfr.pm> (raw)
In-Reply-To: <nycvar.YFH.7.76.2003170154580.19500@cbobk.fhfr.pm>
On Tue, 17 Mar 2020, Jiri Kosina wrote:
> > The flag change happened at https://gcc.gnu.org/PR92046.
> >
> > CC: Jiri Kosina <jkosina@suse.cz>
> > CC: Masahiro Yamada <masahiroy@kernel.org>
> > CC: Michal Marek <michal.lkml@markovi.net>
> > CC: linux-kbuild@vger.kernel.org
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > ---
> > Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Makefile b/Makefile
> > index 171f2b004c8a..9696eb2cd5a1 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -714,6 +714,7 @@ endif
> >
> > # Tell gcc to never replace conditional load with a non-conditional one
> > KBUILD_CFLAGS += $(call cc-option,--param=allow-store-data-races=0)
> > +KBUILD_CFLAGS += $(call cc-option,-fno-allow-store-data-races)
>
> I have to say I can't really read gcc sources without major cerebral pain,
> so let me me dense here: what happens to gcc<10 if you pass
> -fno-allow-store-data-races to it?
Sorry, brainfart on my side, your patch is good :)
Acked-by: Jiri Kosina <jkosina@suse.cz>
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2020-03-17 1:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 0:07 [PATCH] Makefile: disallow data races on gcc-10 as well Sergei Trofimovich
2020-03-17 0:57 ` Jiri Kosina
2020-03-17 1:41 ` Jiri Kosina [this message]
2020-03-19 15:34 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2003170240410.19500@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.