Re: [PATCH] HID: intel-ish-hid: use async resume function

From: Jiri Kosina <jikos@kernel.org>
To: Ye Xiang <xiang.ye@intel.com>
Cc: jic23@kernel.org, srinivas.pandruvada@linux.intel.com,
	linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: use async resume function
Date: Thu, 15 Jul 2021 20:51:43 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2107152051340.8253@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210613032507.7474-1-xiang.ye@intel.com>

On Sun, 13 Jun 2021, Ye Xiang wrote:

> ISH IPC driver uses asynchronous workqueue to do resume now, but there is
> a potential timing issue: when child devices resume before bus driver, it
> will cause child devices resume failed and cannot be recovered until
> reboot. The current implementation in this case do wait for IPC to resume
> but fail to accommodate for a case when there is no ISH reboot and soft
> resume is taking time. This issue is apparent on Tiger Lake platform with
> 5.11.13 kernel when doing suspend to idle then resume(s0ix) test. To
> resolve this issue, we change ISHTP HID client to use asynchronous resume
> callback too. In the asynchronous resume callback, it waits for the ISHTP
> resume done event, and then notify ISHTP HID client link ready.
> 
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs