Re: [PATCH] HID: Add driver for Razer Blackwidow keyboards

From: Jiri Kosina <jikos@kernel.org>
To: Jelle van der Waa <jelle@vdwaa.nl>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Jelle van der Waa <jvanderwaa@redhat.com>,
	linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add driver for Razer Blackwidow keyboards
Date: Fri, 14 Jan 2022 14:16:36 +0100 (CET)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2201141412480.28059@cbobk.fhfr.pm> (raw)
In-Reply-To: <20211231112500.8350-1-jvanderwaa@redhat.com>

On Fri, 31 Dec 2021, Jelle van der Waa wrote:

> Add a driver to enable the macro keys (M1 - M5) by default, these are
> mapped to XF86Tools and XF86Launch5 - XF86Launch8. The driver remaps
> them by default to macro keys with an option to retain the old mapping
> which users most likely already use as there are many scripts to enable
> the macro keys available on Github and other websites.
> 
> Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>

Thanks for the patch.

In order to follow the usual HID driver naming convention, could you 
please name the driver according to the vendor hid-razer, with the outlook 
of extending in further with more devices from the same vendor, as needed?

Thanks,

-- 
Jiri Kosina
SUSE Labs