From: Joseph Qi <jiangqi903@gmail.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2: clear links count in ocfs2_mknod() if an error occurs
Date: Mon, 1 Jun 2020 16:30:30 +0800 [thread overview]
Message-ID: <09b83918-89aa-2f5c-bbbf-ea4470386bfe@gmail.com> (raw)
In-Reply-To: <d8147c41-fb2b-bdf7-b660-1f3c8448c33f@huawei.com>
Hi,
On 2020/5/26 15:45, Wangyan wrote:
> In this condition, the inode can not be wiped when error happened.
> ocfs2_mkdir()
> ->ocfs2_mknod()
> ->ocfs2_mknod_locked()
> ->__ocfs2_mknod_locked()
> ->ocfs2_set_links_count() // i_links_count is 2
> -> ... // an error accrue, goto roll_back or leave.
> ->ocfs2_commit_trans()
> ->iput(inode)
> ->evict()
> ->ocfs2_evict_inode()
> ->ocfs2_delete_inode()
> ->ocfs2_inode_lock()
> ->ocfs2_inode_lock_update()
> ->ocfs2_refresh_inode()
> ->set_nlink(); // inode->i_nlink is 2 now.
> /* if wipe is 0, it will goto bail_unlock_inode */
> ->ocfs2_query_inode_wipe()
> ->if (inode->i_nlink) return; // wipe is 0.
> /* inode can not be wiped */
> ->ocfs2_wipe_inode()
> So, we need clear links before the transaction committed.
>
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
> ---
> fs/ocfs2/namei.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 5381020aaa9a..e61fdd8972ec 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -453,8 +453,12 @@ static int ocfs2_mknod(struct inode *dir,
> leave:
> if (status < 0 && did_quota_inode)
> dquot_free_inode(inode);
> - if (handle)
> + if (handle) {
> + if (status < 0 && new_fe_bh != NULL)
> + ocfs2_set_links_count((struct ocfs2_dinode *)
> + new_fe_bh->b_data, 0);
Seems no need to do this rollback under handle?
Only if (status < 0 && new_fe_bh) will be okay.
> ocfs2_commit_trans(osb, handle);
> + }
>
> ocfs2_inode_unlock(dir, 1);
> if (did_block_signals)
> @@ -598,6 +602,8 @@ static int __ocfs2_mknod_locked(struct inode *dir,
> leave:
> if (status < 0) {
> if (*new_fe_bh) {
> + if (fe)
> + ocfs2_set_links_count(fe, 0);
Leave this to caller will be enough.
Thanks,
Joseph
> brelse(*new_fe_bh);> *new_fe_bh = NULL;
> }
> @@ -2023,8 +2029,12 @@ static int ocfs2_symlink(struct inode *dir,
> ocfs2_clusters_to_bytes(osb->sb, 1));
> if (status < 0 && did_quota_inode)
> dquot_free_inode(inode);
> - if (handle)
> + if (handle) {
> + if (status < 0 && new_fe_bh != NULL)
> + ocfs2_set_links_count((struct ocfs2_dinode *)
> + new_fe_bh->b_data, 0);
> ocfs2_commit_trans(osb, handle);
> + }
>
> ocfs2_inode_unlock(dir, 1);
> if (did_block_signals)
>
next prev parent reply other threads:[~2020-06-01 8:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 7:45 [Ocfs2-devel] [PATCH 1/2] ocfs2: clear links count in ocfs2_mknod() if an error occurs Wangyan
2020-05-27 22:52 ` Andrew Morton
2020-05-28 0:43 ` Wangyan
2020-06-01 8:30 ` Joseph Qi [this message]
2020-08-07 3:49 ` Andrew Morton
2022-10-16 23:32 ` Andrew Morton via Ocfs2-devel
2022-10-17 1:57 ` Joseph Qi via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b83918-89aa-2f5c-bbbf-ea4470386bfe@gmail.com \
--to=jiangqi903@gmail.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).