From: Joseph Qi via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Wengang Wang <wen.gang.wang@oracle.com>,
ryan.ding@oracle.com, Junxiao Bi <junxiao.bi@oracle.com>
Cc: Sunil Mushran <sunil.mushran@oracle.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: fix uninitialized variable in ocfs2_dio_wr_get_block()
Date: Mon, 6 Dec 2021 14:03:13 +0800 [thread overview]
Message-ID: <1e9cb07e-aef7-1461-25c4-1e9cfbe41c12@linux.alibaba.com> (raw)
In-Reply-To: <92d4d393-9734-9f7e-4440-20429bdac14f@linux.alibaba.com>
On 12/1/21 10:24 AM, Joseph Qi wrote:
>
>
> On 11/30/21 6:40 PM, Dan Carpenter wrote:
>> The callers assume that "*fsdata" is set on the success path, but
>> that's not necessarily true on this path.
>>
>
> In ocfs2_page_mkwrite(), since in this case no target page locked, it
> will finally return VM_FAULT_NOPAGE (better VM_FAULT_RETRY?) and throw
> to handle_mm_fault(). So no problem as comments described.
>
> But things seems changed since append direct io path started to use
> write_[begin/end]. In this path, the target page is expected as NULL.
> This needs more discussion.
>
ocfs2_grab_pages_for_write() returns EAGAIN only in case of mmap. So
current code won't have any issue.
I'll send a cleanup to make the code more clearly.
Thanks,
Joseph
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
prev parent reply other threads:[~2021-12-06 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 10:40 [Ocfs2-devel] [PATCH] ocfs2: fix uninitialized variable in ocfs2_dio_wr_get_block() Dan Carpenter via Ocfs2-devel
2021-12-01 2:24 ` Joseph Qi via Ocfs2-devel
2021-12-06 6:03 ` Joseph Qi via Ocfs2-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e9cb07e-aef7-1461-25c4-1e9cfbe41c12@linux.alibaba.com \
--to=ocfs2-devel@oss.oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=junxiao.bi@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan.ding@oracle.com \
--cc=sunil.mushran@oracle.com \
--cc=wen.gang.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).