From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org,
Gao Xiang <gaoxiang25@huawei.com>,
Dave Chinner <dchinner@redhat.com>,
William Kucharski <william.kucharski@oracle.com>,
Chao Yu <yuchao0@huawei.com>
Subject: [Ocfs2-devel] [PATCH v11 19/25] erofs: Convert compressed files from readpages to readahead
Date: Mon, 20 Apr 2020 22:42:10 -0700 [thread overview]
Message-ID: <20200420224210.dff005bc62957a4d81d58226@linux-foundation.org> (raw)
In-Reply-To: <20200414150233.24495-20-willy@infradead.org>
On Tue, 14 Apr 2020 08:02:27 -0700 Matthew Wilcox <willy@infradead.org> wrote:
>
> Use the new readahead operation in erofs.
>
Well this is exciting.
fs/erofs/data.c: In function erofs_raw_access_readahead:
fs/erofs/data.c:149:18: warning: last_block may be used uninitialized in this function [-Wmaybe-uninitialized]
*last_block + 1 != current_block) {
It seems to be a preexisting bug, which your patch prompted gcc-7.2.0
to notice.
erofs_read_raw_page() goes in and uses *last_block, but neither of its
callers has initialized it. Could the erofs maintainers please take a
look?
next prev parent reply other threads:[~2020-04-21 5:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 15:02 [Ocfs2-devel] [PATCH v11 00/25] Change readahead API Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 01/25] mm: Move readahead prototypes from mm.h Matthew Wilcox
2020-04-15 9:10 ` Johannes Thumshirn
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 02/25] mm: Return void from various readahead functions Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 03/25] mm: Ignore return value of ->readpages Matthew Wilcox
2020-04-15 9:17 ` Johannes Thumshirn
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 04/25] mm: Move readahead nr_pages check into read_pages Matthew Wilcox
2020-04-15 9:19 ` Johannes Thumshirn
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 05/25] mm: Add new readahead_control API Matthew Wilcox
2020-04-15 1:17 ` Andrew Morton
2020-04-15 2:18 ` Matthew Wilcox
2020-04-15 4:56 ` Andrew Morton
2020-04-15 11:22 ` Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 06/25] mm: Use readahead_control to pass arguments Matthew Wilcox
2020-04-15 9:30 ` Johannes Thumshirn
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 07/25] mm: Rename various 'offset' parameters to 'index' Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 08/25] mm: rename readahead loop variable to 'i' Matthew Wilcox
2020-04-15 9:31 ` Johannes Thumshirn
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 09/25] mm: Remove 'page_offset' from readahead loop Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 10/25] mm: Put readahead pages in cache earlier Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 11/25] mm: Add readahead address space operation Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 12/25] mm: Move end_index check out of readahead loop Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 13/25] mm: Add page_cache_readahead_unbounded Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 14/25] mm: Document why we don't set PageReadahead Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 15/25] mm: Use memalloc_nofs_save in readahead path Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 16/25] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-06-16 22:36 ` [Ocfs2-devel] [Cluster-devel] " Andreas Gruenbacher
2020-06-17 0:32 ` Matthew Wilcox
2020-06-17 0:57 ` Andreas Grünbacher
2020-06-17 2:21 ` Matthew Wilcox
2020-06-18 12:46 ` Andreas Gruenbacher
2020-06-18 15:03 ` Matthew Wilcox
2020-06-18 16:40 ` Andreas Gruenbacher
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 17/25] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 18/25] erofs: Convert uncompressed files " Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 19/25] erofs: Convert compressed " Matthew Wilcox
2020-04-21 5:42 ` Andrew Morton [this message]
2020-04-21 7:28 ` Gao Xiang
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 20/25] ext4: Convert " Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 21/25] ext4: Pass the inode to ext4_mpage_readpages Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 22/25] f2fs: Convert from readpages to readahead Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 23/25] f2fs: Pass the inode to f2fs_mpage_readpages Matthew Wilcox
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 24/25] fuse: Convert from readpages to readahead Matthew Wilcox
2020-04-20 11:14 ` Miklos Szeredi
2020-04-20 11:43 ` Matthew Wilcox
2020-04-20 11:54 ` Miklos Szeredi
2020-04-14 15:02 ` [Ocfs2-devel] [PATCH v11 25/25] iomap: " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420224210.dff005bc62957a4d81d58226@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=dchinner@redhat.com \
--cc=gaoxiang25@huawei.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).