From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Tao pilgrim <pilgrimtao@gmail.com>, Jens Axboe <axboe@kernel.dk>,
sth@linux.ibm.com, viro@zeniv.linux.org.uk, clm@fb.com,
jaegeuk@kernel.org, hch@infradead.org,
Mark Fasheh <mark@fasheh.com>,
dhowells@redhat.com, balbi@kernel.org, damien.lemoal@wdc.com,
bvanassche@acm.org, ming.lei@redhat.com,
martin.petersen@oracle.com, satyat@google.com,
chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
asml.silence@gmail.com, ajay.joshi@wdc.com,
linux-kernel@vger.kernel.org,
Muchun Song <songmuchun@bytedance.com>,
hoeppner@linux.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com, borntraeger@de.ibm.com,
linux-s390@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-usb@vger.kernel.org,
Josef Bacik <josef@toxicpanda.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org, chao@kernel.org,
linux-f2fs-devel@lists.sourceforge.net, darrick.wong@oracle.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
ocfs2-devel@oss.oracle.com, deepa.kernel@gmail.com
Subject: [Ocfs2-devel] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()
Date: Tue, 2 Jun 2020 08:13:05 +0200 [thread overview]
Message-ID: <20200602061305.GA2258861@kroah.com> (raw)
In-Reply-To: <20200602055152.GA11620@lst.de>
On Tue, Jun 02, 2020 at 07:51:52AM +0200, Christoph Hellwig wrote:
> On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote:
> > But does this code path actually show up anywhere that is actually
> > measurable as mattering?
> >
> > If so, please show that benchmark results.
>
> I think the requests are starting to be a bit unreasonable. Tao is
> replacing a reimplementation of a standard function with that standard
> function / compiler builtin. We don't put such a high burden on that.
That's fine, but to say it is "faster" usually means we want to see it
actually going faster somehow :)
> And once the proper existing fields are used where possible as shown
> in my reply just replacing the rest seems totally obvious - quite
> contrary I think keeping a reimplementation would need a high bar.
Your patch makes sense, I was not objecting to that.
thanks,
greg k-h
next prev parent reply other threads:[~2020-06-02 6:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 14:11 [Ocfs2-devel] [PATCH v2] blkdev: Replace blksize_bits() with ilog2() Kaitao Cheng
2020-05-29 14:13 ` Jens Axboe
2020-06-01 7:22 ` Tao pilgrim
2020-06-01 8:44 ` Greg KH
2020-06-02 5:51 ` Christoph Hellwig
2020-06-02 6:13 ` Greg KH [this message]
2020-05-29 14:15 ` Christoph Hellwig
2020-05-29 20:27 ` Matthew Wilcox
2020-05-29 22:27 ` Bart Van Assche
2020-05-29 22:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602061305.GA2258861@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ajay.joshi@wdc.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=borntraeger@de.ibm.com \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=deepa.kernel@gmail.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.com \
--cc=gor@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hoeppner@linux.ibm.com \
--cc=houtao1@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=pilgrimtao@gmail.com \
--cc=sagi@grimberg.me \
--cc=satyat@google.com \
--cc=songmuchun@bytedance.com \
--cc=sth@linux.ibm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).