From: Matthew Wilcox (Oracle) <willy@infradead.org>
To: linux-fsdevel@vger.kernel.org
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
ericvh@gmail.com, lucho@ionkov.net, viro@zeniv.linux.org.uk,
jlayton@kernel.org, idryomov@gmail.com, mark@fasheh.com,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
v9fs-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
stable@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH 3/7] ceph: Promote to unsigned long long before shifting
Date: Sun, 4 Oct 2020 19:04:24 +0100 [thread overview]
Message-ID: <20201004180428.14494-4-willy@infradead.org> (raw)
In-Reply-To: <20201004180428.14494-1-willy@infradead.org>
On 32-bit systems, this shift will overflow for files larger than 4GB.
Cc: stable at vger.kernel.org
Fixes: 61f68816211e ("ceph: check caps in filemap_fault and page_mkwrite")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
fs/ceph/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 6ea761c84494..970e5a094035 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1522,7 +1522,7 @@ static vm_fault_t ceph_filemap_fault(struct vm_fault *vmf)
struct ceph_inode_info *ci = ceph_inode(inode);
struct ceph_file_info *fi = vma->vm_file->private_data;
struct page *pinned_page = NULL;
- loff_t off = vmf->pgoff << PAGE_SHIFT;
+ loff_t off = (loff_t)vmf->pgoff << PAGE_SHIFT;
int want, got, err;
sigset_t oldset;
vm_fault_t ret = VM_FAULT_SIGBUS;
--
2.28.0
next prev parent reply other threads:[~2020-10-04 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 18:04 [Ocfs2-devel] [PATCH 0/7] Fix a pile of 4GB file problems on 32-bit Matthew Wilcox
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 1/7] 9P: Cast to loff_t before multiplying Matthew Wilcox
2020-10-07 5:48 ` Christoph Hellwig
2020-10-07 18:47 ` Matthew Wilcox
2020-10-26 17:14 ` Dominique Martinet
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 2/7] buffer: Promote to unsigned long long before shifting Matthew Wilcox
2020-10-04 18:04 ` Matthew Wilcox [this message]
2020-10-06 11:29 ` [Ocfs2-devel] [PATCH 3/7] ceph: " Jeff Layton
2020-10-06 17:20 ` Jeff Layton
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 4/7] ocfs2: " Matthew Wilcox
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 5/7] btrfs: " Matthew Wilcox
2020-10-09 14:18 ` Josef Bacik
2020-10-26 17:02 ` David Sterba
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 6/7] " Matthew Wilcox
2020-10-09 14:18 ` Josef Bacik
2020-10-26 16:35 ` David Sterba
2020-10-26 16:44 ` Matthew Wilcox
2020-10-26 17:03 ` David Sterba
2020-10-04 18:04 ` [Ocfs2-devel] [PATCH 7/7] btrfs: Promote to unsigned long long before multiplying Matthew Wilcox
2020-10-26 16:21 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201004180428.14494-4-willy@infradead.org \
--to=willy@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=ericvh@gmail.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=stable@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
--subject='Re: [Ocfs2-devel] [PATCH 3/7] ceph: Promote to unsigned long long before shifting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).