From: Jeff Layton <jlayton@kernel.org>
To: torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org,
linux-doc@vger.kernel.org, david@redhat.com,
stable@vger.kernel.org, cluster-devel@redhat.com,
linux-mm@kvack.org, rostedt@goodmis.org, viro@zeniv.linux.org.uk,
luto@kernel.org, v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, ocfs2-devel@oss.oracle.com,
ebiederm@xmission.com
Subject: [Ocfs2-devel] [PATCH v3 1/2] fs: warn about impending deprecation of mandatory locks
Date: Fri, 20 Aug 2021 12:39:18 -0400 [thread overview]
Message-ID: <20210820163919.435135-2-jlayton@kernel.org> (raw)
In-Reply-To: <20210820163919.435135-1-jlayton@kernel.org>
We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
have disabled it. Warn the stragglers that still use "-o mand" that
we'll be dropping support for that mount option.
Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/namespace.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/namespace.c b/fs/namespace.c
index ab4174a3c802..2279473d0d6f 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -1716,8 +1716,12 @@ static inline bool may_mount(void)
}
#ifdef CONFIG_MANDATORY_FILE_LOCKING
-static inline bool may_mandlock(void)
+static bool may_mandlock(void)
{
+ pr_warn_once("======================================================\n"
+ "WARNING: the mand mount option is being deprecated and\n"
+ " will be removed in v5.15!\n"
+ "======================================================\n");
return capable(CAP_SYS_ADMIN);
}
#else
--
2.31.1
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2021-08-20 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 16:39 [Ocfs2-devel] [PATCH v3 0/2] fs: remove support for mandatory locking Jeff Layton
2021-08-20 16:39 ` Jeff Layton [this message]
2021-08-20 16:39 ` [Ocfs2-devel] [PATCH v3 2/2] fs: remove mandatory file locking support Jeff Layton
2021-08-20 19:45 ` Al Viro
2021-08-23 15:12 ` Guenter Roeck
2021-08-20 18:15 ` [Ocfs2-devel] [PATCH v3 0/2] fs: remove support for mandatory locking Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820163919.435135-2-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=bfields@fieldses.org \
--cc=cluster-devel@redhat.com \
--cc=david@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luto@kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).