From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Gang He <ghe@suse.com>, mark@fasheh.com, jlbec@evilplan.org
Cc: linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v2] ocfs2: ocfs2_downconvert_lock failure results in deadlock
Date: Mon, 30 Aug 2021 19:05:14 +0800 [thread overview]
Message-ID: <471dd2b4-fb62-3f4a-dbf3-cbf2340aed6f@linux.alibaba.com> (raw)
In-Reply-To: <20210830044621.12544-1-ghe@suse.com>
On 8/30/21 12:46 PM, Gang He wrote:
> Usually, ocfs2_downconvert_lock() function always downconverts
> dlm lock to the expected level for satisfy dlm bast requests
> from the other nodes.
> But there is a rare situation. When dlm lock conversion is being
> canceled, ocfs2_downconvert_lock() function will return -EBUSY.
> You need to be aware that ocfs2_cancel_convert() function is
> asynchronous in fsdlm implementation.
> If we does not requeue this lockres entry, ocfs2 downconvert
> thread no longer handles this dlm lock bast request. Then, the
> other nodes will not get the dlm lock again, the current node's
> process will be blocked when acquire this dlm lock again.
>
> Signed-off-by: Gang He <ghe@suse.com>
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> v2: keep error print in ocfs2_downconvert_lock function, add more detailed
> comments in code, add msleep to avoid repeated attempts.
> ---
> fs/ocfs2/dlmglue.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 48fd369c29a4..f8f561850470 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -16,6 +16,7 @@
> #include <linux/debugfs.h>
> #include <linux/seq_file.h>
> #include <linux/time.h>
> +#include <linux/delay.h>
> #include <linux/quotaops.h>
> #include <linux/sched/signal.h>
>
> @@ -3912,6 +3913,17 @@ static int ocfs2_unblock_lock(struct ocfs2_super *osb,
> spin_unlock_irqrestore(&lockres->l_lock, flags);
> ret = ocfs2_downconvert_lock(osb, lockres, new_level, set_lvb,
> gen);
> + /* The dlm lock convert is being cancelled in background,
> + * ocfs2_cancel_convert() is asynchronous in fs/dlm,
> + * requeue it, try again later.
> + */
> + if (ret == -EBUSY) {
> + ctl->requeue = 1;
> + mlog(ML_BASTS, "lockres %s, ReQ: Downconvert busy\n",
> + lockres->l_name);
> + ret = 0;
> + msleep(20);
> + }
>
> leave:
> if (ret)
>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
prev parent reply other threads:[~2021-08-30 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 4:46 [Ocfs2-devel] [PATCH v2] ocfs2: ocfs2_downconvert_lock failure results in deadlock Gang He
2021-08-30 11:05 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471dd2b4-fb62-3f4a-dbf3-cbf2340aed6f@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=ghe@suse.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).