ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
* [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
@ 2021-09-03  1:26 Wengang Wang
  2021-09-03  4:54 ` Greg KH
  2021-09-06 11:42 ` Joseph Qi
  0 siblings, 2 replies; 6+ messages in thread
From: Wengang Wang @ 2021-09-03  1:26 UTC (permalink / raw)
  To: ocfs2-devel; +Cc: stable

ocfs2_data_convert_worker() is currently dropping any cached acl info
for FILE before down-converting meta lock. It should also drop for DIRECTORY.
Otherwise the second acl lookup returns the cached one (from VFS layer) which
could be already stale.

The problem we are seeing is that the acl changes on one node doesn't get
refreshed on other nodes in the following case:

  Node 1                    Node 2
--------------            ----------------
getfacl dir1

			  getfacl dir1    <-- this is OK

setfacl -m u:user1:rwX dir1
getfacl dir1   <-- see the change for user1

			  getfacl dir1    <-- can't see change for user1

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
 fs/ocfs2/dlmglue.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 50a863fc1779..207ec61569ea 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
 		oi = OCFS2_I(inode);
 		oi->ip_dir_lock_gen++;
 		mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
-		goto out;
+		goto out_forget;
 	}
 
 	if (!S_ISREG(inode->i_mode))
@@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
 		filemap_fdatawait(mapping);
 	}
 
+out_forget:
 	forget_all_cached_acls(inode);
 
 out:
-- 
2.21.0 (Apple Git-122.2)


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
  2021-09-03  1:26 [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too Wengang Wang
@ 2021-09-03  4:54 ` Greg KH
  2021-09-06 11:42 ` Joseph Qi
  1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-09-03  4:54 UTC (permalink / raw)
  To: Wengang Wang; +Cc: stable, ocfs2-devel

On Thu, Sep 02, 2021 at 06:26:31PM -0700, Wengang Wang wrote:
> ocfs2_data_convert_worker() is currently dropping any cached acl info
> for FILE before down-converting meta lock. It should also drop for DIRECTORY.
> Otherwise the second acl lookup returns the cached one (from VFS layer) which
> could be already stale.
> 
> The problem we are seeing is that the acl changes on one node doesn't get
> refreshed on other nodes in the following case:
> 
>   Node 1                    Node 2
> --------------            ----------------
> getfacl dir1
> 
> 			  getfacl dir1    <-- this is OK
> 
> setfacl -m u:user1:rwX dir1
> getfacl dir1   <-- see the change for user1
> 
> 			  getfacl dir1    <-- can't see change for user1
> 
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
>  fs/ocfs2/dlmglue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 50a863fc1779..207ec61569ea 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>  		oi = OCFS2_I(inode);
>  		oi->ip_dir_lock_gen++;
>  		mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
> -		goto out;
> +		goto out_forget;
>  	}
>  
>  	if (!S_ISREG(inode->i_mode))
> @@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>  		filemap_fdatawait(mapping);
>  	}
>  
> +out_forget:
>  	forget_all_cached_acls(inode);
>  
>  out:
> -- 
> 2.21.0 (Apple Git-122.2)
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
  2021-09-03  1:26 [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too Wengang Wang
  2021-09-03  4:54 ` Greg KH
@ 2021-09-06 11:42 ` Joseph Qi
  2021-09-17 16:46   ` Wengang Wang
  1 sibling, 1 reply; 6+ messages in thread
From: Joseph Qi @ 2021-09-06 11:42 UTC (permalink / raw)
  To: Wengang Wang, ocfs2-devel



On 9/3/21 9:26 AM, Wengang Wang wrote:
> ocfs2_data_convert_worker() is currently dropping any cached acl info
> for FILE before down-converting meta lock. It should also drop for DIRECTORY.
> Otherwise the second acl lookup returns the cached one (from VFS layer) which
> could be already stale.
> 
> The problem we are seeing is that the acl changes on one node doesn't get
> refreshed on other nodes in the following case:
> 
>   Node 1                    Node 2
> --------------            ----------------
> getfacl dir1
> 
> 			  getfacl dir1    <-- this is OK
> 
> setfacl -m u:user1:rwX dir1
> getfacl dir1   <-- see the change for user1
> 
> 			  getfacl dir1    <-- can't see change for user1
> 
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>

Looks sane to me.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>

> ---
>  fs/ocfs2/dlmglue.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 50a863fc1779..207ec61569ea 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>  		oi = OCFS2_I(inode);
>  		oi->ip_dir_lock_gen++;
>  		mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
> -		goto out;
> +		goto out_forget;
>  	}
>  
>  	if (!S_ISREG(inode->i_mode))
> @@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>  		filemap_fdatawait(mapping);
>  	}
>  
> +out_forget:
>  	forget_all_cached_acls(inode);
>  
>  out:
> 

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
  2021-09-06 11:42 ` Joseph Qi
@ 2021-09-17 16:46   ` Wengang Wang
  2021-09-18  2:43     ` Joseph Qi
  0 siblings, 1 reply; 6+ messages in thread
From: Wengang Wang @ 2021-09-17 16:46 UTC (permalink / raw)
  To: Joseph Qi, akpm; +Cc: ocfs2-devel ML


[-- Attachment #1.1: Type: text/plain, Size: 1770 bytes --]

Hi Andrew,

Can you pls merge this patch if it’s not already on the way?

thanks,
wengang

On Sep 6, 2021, at 4:42 AM, Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>> wrote:



On 9/3/21 9:26 AM, Wengang Wang wrote:
ocfs2_data_convert_worker() is currently dropping any cached acl info
for FILE before down-converting meta lock. It should also drop for DIRECTORY.
Otherwise the second acl lookup returns the cached one (from VFS layer) which
could be already stale.

The problem we are seeing is that the acl changes on one node doesn't get
refreshed on other nodes in the following case:

 Node 1                    Node 2
--------------            ----------------
getfacl dir1

  getfacl dir1    <-- this is OK

setfacl -m u:user1:rwX dir1
getfacl dir1   <-- see the change for user1

  getfacl dir1    <-- can't see change for user1

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com<mailto:wen.gang.wang@oracle.com>>

Looks sane to me.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>>

---
fs/ocfs2/dlmglue.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
index 50a863fc1779..207ec61569ea 100644
--- a/fs/ocfs2/dlmglue.c
+++ b/fs/ocfs2/dlmglue.c
@@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
oi = OCFS2_I(inode);
oi->ip_dir_lock_gen++;
mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
- goto out;
+ goto out_forget;
}

if (!S_ISREG(inode->i_mode))
@@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
filemap_fdatawait(mapping);
}

+out_forget:
forget_all_cached_acls(inode);

out:


[-- Attachment #1.2: Type: text/html, Size: 9694 bytes --]

[-- Attachment #2: Type: text/plain, Size: 151 bytes --]

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
  2021-09-17 16:46   ` Wengang Wang
@ 2021-09-18  2:43     ` Joseph Qi
  2021-09-20 15:36       ` Wengang Wang
  0 siblings, 1 reply; 6+ messages in thread
From: Joseph Qi @ 2021-09-18  2:43 UTC (permalink / raw)
  To: Wengang Wang, akpm; +Cc: ocfs2-devel ML

It has already been added in -mm tree.

Thanks,
Joseph

On 9/18/21 12:46 AM, Wengang Wang wrote:
> Hi Andrew,
> 
> Can you pls merge this patch if it’s not already on the way?
> 
> thanks,
> wengang
> 
> On Sep 6, 2021, at 4:42 AM, Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>> wrote:
> 
> 
> 
> On 9/3/21 9:26 AM, Wengang Wang wrote:
> ocfs2_data_convert_worker() is currently dropping any cached acl info
> for FILE before down-converting meta lock. It should also drop for DIRECTORY.
> Otherwise the second acl lookup returns the cached one (from VFS layer) which
> could be already stale.
> 
> The problem we are seeing is that the acl changes on one node doesn't get
> refreshed on other nodes in the following case:
> 
>  Node 1                    Node 2
> --------------            ----------------
> getfacl dir1
> 
>   getfacl dir1    <-- this is OK
> 
> setfacl -m u:user1:rwX dir1
> getfacl dir1   <-- see the change for user1
> 
>   getfacl dir1    <-- can't see change for user1
> 
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com<mailto:wen.gang.wang@oracle.com>>
> 
> Looks sane to me.
> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>>
> 
> ---
> fs/ocfs2/dlmglue.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index 50a863fc1779..207ec61569ea 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
> oi = OCFS2_I(inode);
> oi->ip_dir_lock_gen++;
> mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
> - goto out;
> + goto out_forget;
> }
> 
> if (!S_ISREG(inode->i_mode))
> @@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
> filemap_fdatawait(mapping);
> }
> 
> +out_forget:
> forget_all_cached_acls(inode);
> 
> out:
> 

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too
  2021-09-18  2:43     ` Joseph Qi
@ 2021-09-20 15:36       ` Wengang Wang
  0 siblings, 0 replies; 6+ messages in thread
From: Wengang Wang @ 2021-09-20 15:36 UTC (permalink / raw)
  To: Joseph Qi; +Cc: ocfs2-devel ML



> On Sep 17, 2021, at 7:43 PM, Joseph Qi <joseph.qi@linux.alibaba.com> wrote:
> 
> It has already been added in -mm tree.

thanks!
wengang

> 
> Thanks,
> Joseph
> 
> On 9/18/21 12:46 AM, Wengang Wang wrote:
>> Hi Andrew,
>> 
>> Can you pls merge this patch if it’s not already on the way?
>> 
>> thanks,
>> wengang
>> 
>> On Sep 6, 2021, at 4:42 AM, Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>> wrote:
>> 
>> 
>> 
>> On 9/3/21 9:26 AM, Wengang Wang wrote:
>> ocfs2_data_convert_worker() is currently dropping any cached acl info
>> for FILE before down-converting meta lock. It should also drop for DIRECTORY.
>> Otherwise the second acl lookup returns the cached one (from VFS layer) which
>> could be already stale.
>> 
>> The problem we are seeing is that the acl changes on one node doesn't get
>> refreshed on other nodes in the following case:
>> 
>> Node 1                    Node 2
>> --------------            ----------------
>> getfacl dir1
>> 
>>  getfacl dir1    <-- this is OK
>> 
>> setfacl -m u:user1:rwX dir1
>> getfacl dir1   <-- see the change for user1
>> 
>>  getfacl dir1    <-- can't see change for user1
>> 
>> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com<mailto:wen.gang.wang@oracle.com>>
>> 
>> Looks sane to me.
>> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com<mailto:joseph.qi@linux.alibaba.com>>
>> 
>> ---
>> fs/ocfs2/dlmglue.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
>> index 50a863fc1779..207ec61569ea 100644
>> --- a/fs/ocfs2/dlmglue.c
>> +++ b/fs/ocfs2/dlmglue.c
>> @@ -3933,7 +3933,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>> oi = OCFS2_I(inode);
>> oi->ip_dir_lock_gen++;
>> mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
>> - goto out;
>> + goto out_forget;
>> }
>> 
>> if (!S_ISREG(inode->i_mode))
>> @@ -3964,6 +3964,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
>> filemap_fdatawait(mapping);
>> }
>> 
>> +out_forget:
>> forget_all_cached_acls(inode);
>> 
>> out:
>> 

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-09-20 15:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03  1:26 [Ocfs2-devel] [PATCH] ocfs2: drop acl cache for directories too Wengang Wang
2021-09-03  4:54 ` Greg KH
2021-09-06 11:42 ` Joseph Qi
2021-09-17 16:46   ` Wengang Wang
2021-09-18  2:43     ` Joseph Qi
2021-09-20 15:36       ` Wengang Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).