From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87095C433EF for ; Wed, 8 Sep 2021 17:13:11 +0000 (UTC) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36B1361157 for ; Wed, 8 Sep 2021 17:13:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 36B1361157 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=oss.oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 188GxP7J018339; Wed, 8 Sep 2021 17:13:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : references : in-reply-to : content-id : mime-version : cc : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2021-07-09; bh=jy7GgiFw0P4lwLes4rD+GVaHGGHVLz0AFKmOh42YVMM=; b=xMcoeuKz4ZDt86tG17kDTv2C+jfj2weqqmG9z3qUefgVhvra/ws0+d1+f8mRHiJyZ2Sy Ch8awy0AzXvigXOXxWsyVR9NlzEkK87LITg6b5bKWIJXd4HcVzQEs2bADeCu7IM1n6d7 ueO8c8u6UFvVuMTKLTrLNbGkW+jfD+sQHO6dpsw5k4FQNxC5lXle5Z1eZMF9FpzqDom0 tqxwHEyWpOn0rYoXwP6d1aFCwnQDn8KoCwoNlZL2H4fknjqNl+Z8FYrLAX5xdkDxWUPm uymM5P3VGadLFaWWvKO6Li7TwRwUjyo3YSDp//+C8IvOaL5i5khQF3QO5aK00DkPuiZW AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : references : in-reply-to : content-id : mime-version : cc : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2020-01-29; bh=jy7GgiFw0P4lwLes4rD+GVaHGGHVLz0AFKmOh42YVMM=; b=q237zcvAPzGb0NYTSs3HgLSLym7RmG2ItgRwdPK66Sn5UVaWYMWlrcgFBThvGg9DlXlK lNSHYAfqnYZmqHKFCBJlul4fq5JzRkYyMuoiwj0QOhz0/uXjTPGX+GuOsMkmQDLVMhWF JjRVXlWqq3OjXkpt68N75eMUKqC1nM2taYdPqptkeHpyejNgDZigvgmS43WOwP5iRSfx bdUWuDfyWZDQf2rn1fWPGMxsLGKnHCj6L+ytpq3+CCcHlRGrF+pmJs7E/Rlj+NTse4vV MK7lwTETgxrFcKGgve/6CFh6vDC8pIwhHwDd1Z0S44BTFd02JXjL6vYEdqWB1rXL3uN1 KQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3axd8q3gjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 08 Sep 2021 17:13:10 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 188HAIfM163481; Wed, 8 Sep 2021 17:13:09 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 3axst450vg-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Wed, 08 Sep 2021 17:13:08 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mO18F-0005Ze-FV; Wed, 08 Sep 2021 10:13:07 -0700 Received: from userp3030.oracle.com ([156.151.31.80]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mO188-0005ZC-FY for ocfs2-devel@oss.oracle.com; Wed, 08 Sep 2021 10:13:00 -0700 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 188HApeL012775 for ; Wed, 8 Sep 2021 17:13:00 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by userp3030.oracle.com with ESMTP id 3axcq1psk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 08 Sep 2021 17:13:00 +0000 Received: from SN6PR10MB2701.namprd10.prod.outlook.com (2603:10b6:805:45::20) by SA2PR10MB4683.namprd10.prod.outlook.com (2603:10b6:806:112::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.25; Wed, 8 Sep 2021 17:12:58 +0000 Received: from SN6PR10MB2701.namprd10.prod.outlook.com ([fe80::64da:7ae6:af82:ebfe]) by SN6PR10MB2701.namprd10.prod.outlook.com ([fe80::64da:7ae6:af82:ebfe%5]) with mapi id 15.20.4478.025; Wed, 8 Sep 2021 17:12:58 +0000 From: Wengang Wang To: Joseph Qi Thread-Topic: [Ocfs2-devel] [PATCH v2] ocfs2: Fix handle refcount leak in two exception handling paths Thread-Index: AQHXpJ+H0ttR42xfTUiCjMce85OD7KuaYEsA Date: Wed, 8 Sep 2021 17:12:58 +0000 Message-ID: <6018AF95-3613-4D43-A3E6-7BAA0E0BE009@oracle.com> References: <20210908102055.10168-1-cymi20@fudan.edu.cn> <06d9e055-29b9-731c-5a36-d888f2c83188@linux.alibaba.com> In-Reply-To: <06d9e055-29b9-731c-5a36-d888f2c83188@linux.alibaba.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3654.60.0.2.21) authentication-results: linux.alibaba.com; dkim=none (message not signed) header.d=none;linux.alibaba.com; dmarc=none action=none header.from=oracle.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ec2a3e7a-e5fb-43e0-515c-08d972ebe815 x-ms-traffictypediagnostic: SA2PR10MB4683: x-ms-exchange-transport-forked: True x-oracle-tenancy: 1 x-ms-oob-tlc-oobclassifiers: OLM:328; x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Hpfr5HyqI9XnalHLM+nSYJedr5YqWKZirI2D9vLiL+kERgK92w0hfmq0MnQWHmJUJv8eskuBphQAlf9Qyz1Nkw83buIus1zkRF5wardTRC9GsRAhjXj7azepuAuUPWdJtEQ5kPmq6tdtNUmleb9HFDq0HTev4Ls2/56TZ9j5f6EKDphQH+CSCJHLXh+Fo6QVf7rYZ/G6I1xLHIRFkIVh0lhwi/JeCK7dkHrEmM8z65wevo0q53RURmmWA6V/psAbMhf57Q2MbUn0CRzmCh+SltZmtYzkYUcZ00RYVhdrb5wz1xWDS4SBCW9a8rjedHgaJ8jgoDcj4Tyajx1w6wFyf/YDYIEjDrfNr28U9Wk5Gij/8R5NYS7wEGwpBPGnhdZcPA0363NB8s0hrYVAdPBea4dr0MDa40KAg8fosMeVzXbRGStPfK9bG6Kc2EXncFczI83OgMmTCPFETNhJH4j2qC9VBnh0H4FgV/WnFwRie3KYpfMey98MHxDlUbj0SCp80j3qxiEvLQWqyNXDDuIi7nJhsRGy40TUV/npHha7K09NCXT/wtHWAcwh4R+tevQyYqasmklVRVemgj/MId3tuSEiMOzmNRldqSspgK7cA68r56CZQSoDm6U0C5tfrXYMhINBxpda71k8UR/Gy0+qk7yJb2rJ80OVmdo+mHlXZ4jpnhSMh68DsLqDMxT1Y5tH x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:-1; SRV:; IPV:NLI; SFV:SKI; H:SN6PR10MB2701.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:; DIR:INB; Content-ID: MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB2701.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec2a3e7a-e5fb-43e0-515c-08d972ebe815 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2021 17:12:58.4828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lTJYwBhFHzprL5N3VGic8meuvGW4276Rh+vZHHwFMh/pIluHEBr7wzGqKZe5OA2CLQNoWxETn4aICJ0xrzWtCQjW/VOPO4BlnDtmZwRe7JQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4683 X-MS-Exchange-CrossPremises-AuthAs: Internal X-MS-Exchange-CrossPremises-AuthMechanism: 04 X-MS-Exchange-CrossPremises-AuthSource: SN6PR10MB2701.namprd10.prod.outlook.com X-MS-Exchange-CrossPremises-TransportTrafficType: Email X-MS-Exchange-CrossPremises-SCL: -1 X-MS-Exchange-CrossPremises-messagesource: StoreDriver X-MS-Exchange-CrossPremises-BCC: X-MS-Exchange-CrossPremises-originalclientipaddress: 2606:b400:8301:1010::16aa X-MS-Exchange-CrossPremises-transporttraffictype: Email X-MS-Exchange-CrossPremises-antispam-scancontext: DIR:Originating; SFV:SKI; SKIP:0; X-MS-Exchange-CrossPremises-processed-by-journaling: Journal Agent X-OrganizationHeadersPreserved: SA2PR10MB4683.namprd10.prod.outlook.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109080108 Cc: Chenyuan Mi , Xin Tan , Xiyu Yang , "yuanxzhang@fudan.edu.cn" , "linux-kernel@vger.kernel.org" , "ocfs2-devel@oss.oracle.com" Subject: Re: [Ocfs2-devel] [PATCH v2] ocfs2: Fix handle refcount leak in two exception handling paths X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109080108 X-Proofpoint-GUID: cT0FCSWB-TMzrq-yNz2Mi2UsAUf6CSgU X-Proofpoint-ORIG-GUID: cT0FCSWB-TMzrq-yNz2Mi2UsAUf6CSgU SGksDQoNClNvcnJ5IGZvciBsYXRlIGludm9sdmluZywgYnV0IHRoaXMgZG9lc27igJl0IGxvb2sg cmlnaHQgdG8gbWUuDQoNCj4gT24gU2VwIDgsIDIwMjEsIGF0IDM6NTEgQU0sIEpvc2VwaCBRaSA8 am9zZXBoLnFpQGxpbnV4LmFsaWJhYmEuY29tPiB3cm90ZToNCj4gDQo+IA0KPiANCj4gT24gOS84 LzIxIDY6MjAgUE0sIENoZW55dWFuIE1pIHdyb3RlOg0KPj4gVGhlIHJlZmVyZW5jZSBjb3VudGlu ZyBpc3N1ZSBoYXBwZW5zIGluIHR3byBleGNlcHRpb24gaGFuZGxpbmcgcGF0aHMNCj4+IG9mIG9j ZnMyX3JlcGxheV90cnVuY2F0ZV9yZWNvcmRzKCkuIFdoZW4gZXhlY3V0aW5nIHRoZXNlIHR3byBl eGNlcHRpb24NCj4+IGhhbmRsaW5nIHBhdGhzLCB0aGUgZnVuY3Rpb24gZm9yZ2V0cyB0byBkZWNy ZWFzZSB0aGUgcmVmY291bnQgb2YgaGFuZGxlDQo+PiBpbmNyZWFzZWQgYnkgb2NmczJfc3RhcnRf dHJhbnMoKSwgY2F1c2luZyBhIHJlZmNvdW50IGxlYWsuDQo+PiANCj4+IEZpeCB0aGlzIGlzc3Vl IGJ5IHVzaW5nIG9jZnMyX2NvbW1pdF90cmFucygpIHRvIGRlY3JlYXNlIHRoZSByZWZjb3VudA0K Pj4gb2YgaGFuZGxlIGluIHR3byBoYW5kbGluZyBwYXRocy4NCj4+IA0KPj4gU2lnbmVkLW9mZi1i eTogQ2hlbnl1YW4gTWkgPGN5bWkyMEBmdWRhbi5lZHUuY24+DQo+PiBTaWduZWQtb2ZmLWJ5OiBY aXl1IFlhbmcgPHhpeXV5YW5nMTlAZnVkYW4uZWR1LmNuPg0KPj4gU2lnbmVkLW9mZi1ieTogWGlu IFRhbiA8dGFueGluLmN0ZkBnbWFpbC5jb20+DQo+IA0KPiBSZXZpZXdlZC1ieTogSm9zZXBoIFFp IDxqb3NlcGgucWlAbGludXguYWxpYmFiYS5jb20+DQo+PiAtLS0NCj4+IGZzL29jZnMyL2FsbG9j LmMgfCAyICsrDQo+PiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspDQo+PiANCj4+IGRp ZmYgLS1naXQgYS9mcy9vY2ZzMi9hbGxvYy5jIGIvZnMvb2NmczIvYWxsb2MuYw0KPj4gaW5kZXgg ZjFjYzgyNThkMzRhLi5iMDVmZGU3ZWRjM2EgMTAwNjQ0DQo+PiAtLS0gYS9mcy9vY2ZzMi9hbGxv Yy5jDQo+PiArKysgYi9mcy9vY2ZzMi9hbGxvYy5jDQo+PiBAQCAtNTk0MCw2ICs1OTQwLDcgQEAg c3RhdGljIGludCBvY2ZzMl9yZXBsYXlfdHJ1bmNhdGVfcmVjb3JkcyhzdHJ1Y3Qgb2NmczJfc3Vw ZXIgKm9zYiwNCj4+IAkJc3RhdHVzID0gb2NmczJfam91cm5hbF9hY2Nlc3NfZGkoaGFuZGxlLCBJ Tk9ERV9DQUNIRSh0bF9pbm9kZSksIHRsX2JoLA0KPj4gCQkJCQkJIE9DRlMyX0pPVVJOQUxfQUND RVNTX1dSSVRFKTsNCj4+IAkJaWYgKHN0YXR1cyA8IDApIHsNCj4+ICsJCQlvY2ZzMl9jb21taXRf dHJhbnMob3NiLCBoYW5kbGUpOw0KPj4gCQkJbWxvZ19lcnJubyhzdGF0dXMpOw0KPj4gCQkJZ290 byBiYWlsOw0KPj4gCQl9DQo+PiBAQCAtNTk2NCw2ICs1OTY1LDcgQEAgc3RhdGljIGludCBvY2Zz Ml9yZXBsYXlfdHJ1bmNhdGVfcmVjb3JkcyhzdHJ1Y3Qgb2NmczJfc3VwZXIgKm9zYiwNCj4+IAkJ CQkJCSAgICAgZGF0YV9hbGxvY19iaCwgc3RhcnRfYmxrLA0KPj4gCQkJCQkJICAgICBudW1fY2x1 c3RlcnMpOw0KPj4gCQkJaWYgKHN0YXR1cyA8IDApIHsNCj4+ICsJCQkJb2NmczJfY29tbWl0X3Ry YW5zKG9zYiwgaGFuZGxlKTsNCg0KQXMgYSB0cmFuc2FjdGlvbiwgc3R1ZmYgZXhwZWN0ZWQgdG8g YmUgaW4gdGhlIHNhbWUgaGFuZGxlIHNob3VsZCBiZSB0cmVhdGVkIGFzIGF0b21pYy4NCkhlcmUg dGhlIHN0dWZmIGluY2x1ZGVzIHRoZSB0bF9iaCBhbmQgb3RoZXIgbWV0YWRhdGEgYmxvY2sgd2hp Y2ggd2lsbCBiZSBtb2RpZmllZCBpbiBvY2ZzMl9mcmVlX2NsdXN0ZXJzKCkuDQpDb21pbmcgaGVy ZSwgc29tZSBvZiByZWxhdGVkIG1ldGEgYmxvY2tzIG1heSBiZSBpbiB0aGUgaGFuZGxlIGJ1dCBv dGhlcnMgYXJlIG5vdCBkdWUgdG8gdGhlIGVycm9yIGhhcHBlbmVkLg0KSWYgeW91IGRvIGEgY29t bWl0LCBwYXJ0aWFsIG1ldGEgYmxvY2tzIGFyZSBjb21taXR0ZWQgdG8gbG9nLiDigJQgdGhhdCBi cmVha3MgdGhlIGF0b21pYyBpZGVhLCBpdCB3aWxsIGNhdXNlIEZTIGluY29uc2lzdGVuY3kuDQpT byB3aGF04oCZcyByZWFzb24geW91IHdhbnQgdG8gY29tbWl0IHRoZSBtZXRhIGJsb2NrIGNoYW5n ZXMsIHdoaWNoIGlzIG5vdCBhbGwgb2YgZXhwZWN0ZWQsIGluIHRoaXMgaGFuZGxlIHRvIGpvdXJu YWwgbG9nPw0KDQpEbyB5b3UgcmVhbGx5IHNlZSBhIGhpdCBvbiB0aGUgZmFpbHVyZT8gb3IganVz dCB5b3UgZGV0ZWN0ZWQgdGhlIHJlZmNvdW50IGxlYWsgYnkgY29kZSByZXZpZXc/DQoNCllvdSBt YXkgd2FudCB0byBsb29rIGF0IG9jZnMyX2pvdXJuYWxfZGlydHkoKSBmb3IgdGhlIGVycm9yIGhh bmRsaW5nIHBhcnQuDQoNCnRoYW5rcywNCndlbmdhbmcNCg0KDQo+PiAJCQkJbWxvZ19lcnJubyhz dGF0dXMpOw0KPj4gCQkJCWdvdG8gYmFpbDsNCj4+IAkJCX0NCj4+IA0KPiANCj4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gT2NmczItZGV2ZWwgbWFp bGluZyBsaXN0DQo+IE9jZnMyLWRldmVsQG9zcy5vcmFjbGUuY29tDQo+IGh0dHBzOi8vb3NzLm9y YWNsZS5jb20vbWFpbG1hbi9saXN0aW5mby9vY2ZzMi1kZXZlbA0KDQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpPY2ZzMi1kZXZlbCBtYWlsaW5nIGxpc3QK T2NmczItZGV2ZWxAb3NzLm9yYWNsZS5jb20KaHR0cHM6Ly9vc3Mub3JhY2xlLmNvbS9tYWlsbWFu L2xpc3RpbmZvL29jZnMyLWRldmVs