ocfs2-devel.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Tuo Li <islituo@gmail.com>, mark@fasheh.com, jlbec@evilplan.org
Cc: TOTE Robot <oslab@tsinghua.edu.cn>,
	baijiaju1990@gmail.com, linux-kernel@vger.kernel.org,
Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: quota_local: fix possible uninitialized-variable access in ocfs2_local_read_info()
Date: Sat, 31 Jul 2021 21:57:13 +0800	[thread overview]
Message-ID: <607936a1-a21d-7d2f-7a89-2abeb4c5b1d4@linux.alibaba.com> (raw)
In-Reply-To: <20210731075659.73505-1-islituo@gmail.com>

Thanks for the efforts.
For the issue you mentioned, I'd like just initialized
oinfo->dqi_gqinode as NULL before calling ocfs2_global_read_info().
But it seems still have other issues here such as dqi_gqlock.
We need take care all those initialized in ocfs2_global_read_info()


On 7/31/21 3:56 PM, Tuo Li wrote:
> A memory block is allocated through kmalloc(), and its return value is
> assigned to the pointer oinfo. If the return value of
> ocfs2_global_read_info() at line 709 is less than zero,
> oinfo->dqi_gqinode may be not initialized. However, it is accessed at
> line 775:
>   iput(oinfo->dqi_gqinode);
> To fix this possible uninitialized-variable access, replace kmalloc()
> with kzalloc() when allocating memory for oinfo.
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Tuo Li <islituo@gmail.com>
> ---
>  fs/ocfs2/quota_local.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c
> index b1a8b046f4c2..4c1219e08b49 100644
> --- a/fs/ocfs2/quota_local.c
> +++ b/fs/ocfs2/quota_local.c
> @@ -693,7 +693,7 @@ static int ocfs2_local_read_info(struct super_block *sb, int type)
>  	info->dqi_max_spc_limit = 0x7fffffffffffffffLL;
>  	info->dqi_max_ino_limit = 0x7fffffffffffffffLL;
> -	oinfo = kmalloc(sizeof(struct ocfs2_mem_dqinfo), GFP_NOFS);
> +	oinfo = kzalloc(sizeof(struct ocfs2_mem_dqinfo), GFP_NOFS);
>  	if (!oinfo) {
>  		mlog(ML_ERROR, "failed to allocate memory for ocfs2 quota"
>  			       " info.");

Ocfs2-devel mailing list

  reply	other threads:[~2021-07-31 14:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-31  7:56 [Ocfs2-devel] [PATCH] ocfs2: quota_local: fix possible uninitialized-variable access in ocfs2_local_read_info() Tuo Li
2021-07-31 13:57 ` Joseph Qi [this message]
2021-08-01  8:19   ` Li Tuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=607936a1-a21d-7d2f-7a89-2abeb4c5b1d4@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=baijiaju1990@gmail.com \
    --cc=islituo@gmail.com \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=oslab@tsinghua.edu.cn \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).