ocfs2-devel.oss.oracle.com archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: David Laight <David.Laight@ACULAB.COM>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "bfields@fieldses.org" <bfields@fieldses.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"david@redhat.com" <david@redhat.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"w@1wt.eu" <w@1wt.eu>,
	"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"luto@kernel.org" <luto@kernel.org>,
	"v9fs-developer@lists.sourceforge.net"
	<v9fs-developer@lists.sourceforge.net>,
	"linux-afs@lists.infradead.org" <linux-afs@lists.infradead.org>,
	"ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
	"ebiederm@xmission.com" <ebiederm@xmission.com>
Subject: Re: [Ocfs2-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks
Date: Fri, 20 Aug 2021 11:50:51 -0400	[thread overview]
Message-ID: <7efb04fe6e0c867e7c87d75cf3349221b08b4210.camel@kernel.org> (raw)
In-Reply-To: <c1318459eaab436aacb225982c49c4b4@AcuMS.aculab.com>

On Fri, 2021-08-20 at 15:49 +0000, David Laight wrote:
> From: Jeff Layton
> > Sent: 20 August 2021 14:57
> > 
> > We've had CONFIG_MANDATORY_FILE_LOCKING since 2015 and a lot of distros
> > have disabled it. Warn the stragglers that still use "-o mand" that
> > we'll be dropping support for that mount option.
> > 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> >  fs/namespace.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index ab4174a3c802..ffab0bb1e649 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -1716,8 +1716,16 @@ static inline bool may_mount(void)
> >  }
> > 
> >  #ifdef	CONFIG_MANDATORY_FILE_LOCKING
> > +static bool warned_mand;
> >  static inline bool may_mandlock(void)
> >  {
> > +	if (!warned_mand) {
> > +		warned_mand = true;
> > +		pr_warn("======================================================\n");
> > +		pr_warn("WARNING: the mand mount option is being deprecated and\n");
> > +		pr_warn("         will be removed in v5.15!\n");
> > +		pr_warn("======================================================\n");
> > +	}
> >  	return capable(CAP_SYS_ADMIN);
> >  }
> 
> If that is called more than once you don't want the 'inline'.
> I doubt it matters is not inlined - hardly a hot path.
> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
> 

ACK. Of course. That really needs to not be inline. I'll fix that up in
my tree.

Thanks!
-- 
Jeff Layton <jlayton@kernel.org>


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  reply	other threads:[~2021-08-20 15:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 13:57 [Ocfs2-devel] [PATCH v2 0/2] fs: remove support for mandatory locking Jeff Layton
2021-08-20 13:57 ` [Ocfs2-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks Jeff Layton
2021-08-20 15:49   ` David Laight
2021-08-20 15:50     ` Jeff Layton [this message]
2021-08-20 15:52   ` David Hildenbrand
2021-08-20 16:06     ` Jeff Layton
2021-08-20 16:08     ` Steven Rostedt
2021-08-20 13:57 ` [Ocfs2-devel] [PATCH v2 2/2] fs: remove mandatory file locking support Jeff Layton
2021-08-20 14:09 ` [Ocfs2-devel] [PATCH v2 0/2] fs: remove support for mandatory locking J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7efb04fe6e0c867e7c87d75cf3349221b08b4210.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=David.Laight@ACULAB.COM \
    --cc=bfields@fieldses.org \
    --cc=cluster-devel@redhat.com \
    --cc=david@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=rostedt@goodmis.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=v9fs-developer@lists.sourceforge.net \
    --cc=viro@zeniv.linux.org.uk \
    --cc=w@1wt.eu \
    --subject='Re: [Ocfs2-devel] [PATCH v2 1/2] fs: warn about impending deprecation of mandatory locks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).