From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Mauricio Faria de Oliveira <mfo@canonical.com>,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Cc: Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
Subject: [Ocfs2-devel] [PATCH] ocfs2: ratelimit the 'max lookup times reached' notice
Date: Sun, 4 Oct 2020 11:52:16 +0800 [thread overview]
Message-ID: <85ab91b4-00c3-ce0f-2848-a19464337a56@linux.alibaba.com> (raw)
In-Reply-To: <20201001224417.478263-1-mfo@canonical.com>
On 2020/10/2 06:44, Mauricio Faria de Oliveira wrote:
> Running stress-ng on ocfs2 completely fills the kernel log with
> 'max lookup times reached, filesystem may have nested directories.'
>
> Let's ratelimit this message as done with others in the code.
>
> Test-case:
>
> # mkfs.ocfs2 --mount local $DEV
> # mount $DEV $MNT
> # cd $MNT
>
> # dmesg -C
> # stress-ng --dirdeep 1 --dirdeep-ops 1000
> # dmesg | grep -c 'max lookup times reached'
>
> Before:
>
> # dmesg -C
> # stress-ng --dirdeep 1 --dirdeep-ops 1000
> ...
> stress-ng: info: [11116] successful run completed in 3.03s
>
> # dmesg | grep -c 'max lookup times reached'
> 967
>
> After:
>
> # dmesg -C
> # stress-ng --dirdeep 1 --dirdeep-ops 1000
> ...
> stress-ng: info: [739] successful run completed in 0.96s
>
> # dmesg | grep -c 'max lookup times reached'
> 10
>
> # dmesg
> [ 259.086086] ocfs2_check_if_ancestor: 1990 callbacks suppressed
> [ 259.086092] (stress-ng-dirde,740,1):ocfs2_check_if_ancestor:1091 max lookup times reached, filesystem may have nested directories, src inode: 18007, dest inode: 17940.
> ...
>
> Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Looks good to me.
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/namei.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
> index 3c908e9416af..0043eddabdb8 100644
> --- a/fs/ocfs2/namei.c
> +++ b/fs/ocfs2/namei.c
> @@ -1095,8 +1095,8 @@ static int ocfs2_check_if_ancestor(struct ocfs2_super *osb,
> child_inode_no = parent_inode_no;
>
> if (++i >= MAX_LOOKUP_TIMES) {
> - mlog(ML_NOTICE, "max lookup times reached, filesystem "
> - "may have nested directories, "
> + mlog_ratelimited(ML_NOTICE, "max lookup times reached, "
> + "filesystem may have nested directories, "
> "src inode: %llu, dest inode: %llu.\n",
> (unsigned long long)src_inode_no,
> (unsigned long long)dest_inode_no);
>
prev parent reply other threads:[~2020-10-04 3:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 22:44 [Ocfs2-devel] [PATCH] ocfs2: ratelimit the 'max lookup times reached' notice Mauricio Faria de Oliveira
2020-10-04 3:52 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ab91b4-00c3-ce0f-2848-a19464337a56@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=mfo@canonical.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).