From: Paul Moore via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: nicolas.bouchinet@clip-os.org, linux-kernel@vger.kernel.org,
keescook@chromium.org, selinux@vger.kernel.org,
dmitry.kasatkin@gmail.com,
Roberto Sassu <roberto.sassu@huawei.com>,
jmorris@namei.org, zohar@linux.ibm.com,
reiserfs-devel@vger.kernel.org,
linux-security-module@vger.kernel.org, casey@schaufler-ca.com,
eparis@parisplace.org, linux-integrity@vger.kernel.org,
stephen.smalley.work@gmail.com, ocfs2-devel@oss.oracle.com,
serge@hallyn.com
Subject: Re: [Ocfs2-devel] [PATCH v8 1/6] reiserfs: Switch to security_inode_init_security()
Date: Thu, 23 Mar 2023 19:33:40 -0400 [thread overview]
Message-ID: <CAHC9VhS1htA=cFqbc3KJsrZ3by6_m=f3Bd0sTbztC=qMZEvedA@mail.gmail.com> (raw)
In-Reply-To: <20230314081720.4158676-2-roberto.sassu@huaweicloud.com>
On Tue, Mar 14, 2023 at 4:18 AM Roberto Sassu
<roberto.sassu@huaweicloud.com> wrote:
>
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> In preparation for removing security_old_inode_init_security(), switch to
> security_inode_init_security(). Commit 572302af1258 ("reiserfs: Add missing
> calls to reiserfs_security_free()") fixed possible memory leaks and another
> issue related to adding an xattr at inode creation time.
>
> Define the initxattrs callback reiserfs_initxattrs(), to populate the
> name/value/len triple in the reiserfs_security_handle() with the first
> xattr provided by LSMs. Make a copy of the xattr value, as
> security_inode_init_security() frees it.
>
> After the call to security_inode_init_security(), remove the check for
> returning -EOPNOTSUPP, as security_inode_init_security() changes it to
> zero.
>
> Multiple xattrs are currently not supported, as the
> reiserfs_security_handle structure is exported to user space. As a
> consequence, even if EVM is invoked, it will not provide an xattr (if it
> is not the first to set it, its xattr will be discarded; if it is the
> first, it does not have xattrs to calculate the HMAC on).
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> fs/reiserfs/xattr_security.c | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
Merged into lsm/next, thanks.
--
paul-moore.com
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2023-03-23 23:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 8:17 [Ocfs2-devel] [PATCH v8 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Roberto Sassu via Ocfs2-devel
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 1/6] reiserfs: Switch to security_inode_init_security() Roberto Sassu via Ocfs2-devel
2023-03-23 23:33 ` Paul Moore via Ocfs2-devel [this message]
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 2/6] ocfs2: " Roberto Sassu via Ocfs2-devel
2023-03-17 19:39 ` Mimi Zohar via Ocfs2-devel
2023-03-23 23:37 ` Paul Moore via Ocfs2-devel
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 3/6] security: Remove security_old_inode_init_security() Roberto Sassu via Ocfs2-devel
2023-03-23 23:41 ` Paul Moore via Ocfs2-devel
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 4/6] security: Allow all LSMs to provide xattrs for inode_init_security hook Roberto Sassu via Ocfs2-devel
2023-03-24 0:09 ` Paul Moore via Ocfs2-devel
2023-03-24 1:01 ` Casey Schaufler via Ocfs2-devel
2023-03-24 14:17 ` Paul Moore via Ocfs2-devel
2023-03-24 10:18 ` Roberto Sassu via Ocfs2-devel
2023-03-24 13:25 ` Roberto Sassu via Ocfs2-devel
2023-03-24 21:39 ` Paul Moore via Ocfs2-devel
2023-03-27 7:29 ` Roberto Sassu via Ocfs2-devel
2023-03-27 21:02 ` Paul Moore via Ocfs2-devel
2023-03-28 7:46 ` Roberto Sassu via Ocfs2-devel
2023-03-28 20:19 ` Paul Moore via Ocfs2-devel
2023-03-29 7:11 ` Roberto Sassu via Ocfs2-devel
2023-03-24 21:19 ` Paul Moore via Ocfs2-devel
2023-03-27 7:35 ` Roberto Sassu via Ocfs2-devel
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 5/6] evm: Align evm_inode_init_security() definition with LSM infrastructure Roberto Sassu via Ocfs2-devel
2023-03-14 8:17 ` [Ocfs2-devel] [PATCH v8 6/6] evm: Support multiple LSMs providing an xattr Roberto Sassu via Ocfs2-devel
2023-03-14 8:21 ` [Ocfs2-devel] [PATCH v8 0/6] evm: Do HMAC of multiple per LSM xattrs for new inodes Roberto Sassu via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhS1htA=cFqbc3KJsrZ3by6_m=f3Bd0sTbztC=qMZEvedA@mail.gmail.com' \
--to=ocfs2-devel@oss.oracle.com \
--cc=casey@schaufler-ca.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nicolas.bouchinet@clip-os.org \
--cc=paul@paul-moore.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).