From: "Andreas Grünbacher" <andreas.gruenbacher@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: cluster-devel <cluster-devel@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v3 7/7] gfs2: Fix mmap + page fault deadlocks for direct I/O
Date: Mon, 26 Jul 2021 19:50:23 +0200 [thread overview]
Message-ID: <CAHpGcMLOZhZ7tGrY7rcYWUwx12sY884T=eC-Ckna63PBmF=zwA@mail.gmail.com> (raw)
In-Reply-To: <20210726170250.GL20621@quack2.suse.cz>
[-- Attachment #1.1: Type: text/plain, Size: 2216 bytes --]
Jan Kara <jack@suse.cz> schrieb am Mo., 26. Juli 2021, 19:10:
> On Fri 23-07-21 22:58:40, Andreas Gruenbacher wrote:
> > Also disable page faults during direct I/O requests and implement the
> same kind
> > of retry logic as in the buffered I/O case.
> >
> > Direct I/O requests differ from buffered I/O requests in that they use
> > bio_iov_iter_get_pages for grabbing page references and faulting in pages
> > instead of triggering real page faults. Those manual page faults can be
> > disabled with the iocb->noio flag.
> >
> > Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> > ---
> > fs/gfs2/file.c | 34 +++++++++++++++++++++++++++++++++-
> > 1 file changed, 33 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c
> > index f66ac7f56f6d..7986f3be69d2 100644
> > --- a/fs/gfs2/file.c
> > +++ b/fs/gfs2/file.c
> > @@ -782,21 +782,41 @@ static ssize_t gfs2_file_direct_read(struct kiocb
> *iocb, struct iov_iter *to,
> > struct file *file = iocb->ki_filp;
> > struct gfs2_inode *ip = GFS2_I(file->f_mapping->host);
> > size_t count = iov_iter_count(to);
> > + size_t written = 0;
> > ssize_t ret;
> >
> > + /*
> > + * In this function, we disable page faults when we're holding the
> > + * inode glock while doing I/O. If a page fault occurs, we drop
> the
> > + * inode glock, fault in the pages manually, and then we retry.
> Other
> > + * than in gfs2_file_read_iter, iomap_dio_rw can trigger implicit
> as
> > + * well as manual page faults, and we need to disable both kinds
> > + * separately.
> > + */
> > +
> > if (!count)
> > return 0; /* skip atime */
> >
> > gfs2_holder_init(ip->i_gl, LM_ST_DEFERRED, 0, gh);
> > +retry:
> > ret = gfs2_glock_nq(gh);
> > if (ret)
> > goto out_uninit;
> >
> > + pagefault_disable();
>
> Is there any use in pagefault_disable() here? iomap_dio_rw() should not
> trigger any page faults anyway, should it?
>
It can trigger physical page faults when reading from holes.
Andreas
> Honza
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>
[-- Attachment #1.2: Type: text/html, Size: 3340 bytes --]
[-- Attachment #2: Type: text/plain, Size: 151 bytes --]
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2021-07-26 17:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 20:58 [Ocfs2-devel] [PATCH v3 0/7] gfs2: Fix mmap + page fault deadlocks Andreas Gruenbacher
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 1/7] iov_iter: Introduce fault_in_iov_iter helper Andreas Gruenbacher
2021-07-23 23:40 ` Linus Torvalds
2021-07-24 7:51 ` Andreas Grünbacher
2021-07-24 1:52 ` Al Viro
2021-07-24 8:05 ` Andreas Grünbacher
2021-07-26 16:33 ` Jan Kara
2021-07-26 17:15 ` Linus Torvalds
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 2/7] gfs2: Add wrapper for iomap_file_buffered_write Andreas Gruenbacher
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 3/7] gfs2: Fix mmap + page fault deadlocks for buffered I/O Andreas Gruenbacher
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 4/7] iomap: Fix iomap_dio_rw return value for user copies Andreas Gruenbacher
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 5/7] iomap: Support restarting direct I/O requests after user copy failures Andreas Gruenbacher
2021-07-26 17:19 ` Jan Kara
2021-07-26 17:45 ` Andreas Grünbacher
2021-07-26 18:08 ` Jan Kara
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 6/7] iov_iter: Introduce noio flag to disable page faults Andreas Gruenbacher
2021-07-23 20:58 ` [Ocfs2-devel] [PATCH v3 7/7] gfs2: Fix mmap + page fault deadlocks for direct I/O Andreas Gruenbacher
2021-07-26 17:02 ` Jan Kara
2021-07-26 17:50 ` Andreas Grünbacher [this message]
2021-07-26 18:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHpGcMLOZhZ7tGrY7rcYWUwx12sY884T=eC-Ckna63PBmF=zwA@mail.gmail.com' \
--to=andreas.gruenbacher@gmail.com \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).