ocfs2-devel.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Jens Axboe" <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
	"Song Liu" <song@kernel.org>,
	"Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
	"Andreas Dilger" <adilger.kernel@dilger.ca>,
	"Jan Kara" <jack@suse.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	linux-ext4@vger.kernel.org, "Jack Wang" <jinpu.wang@ionos.com>,
	ocfs2-devel@oss.oracle.com, drbd-dev@lists.linbit.com
Subject: Re: [Ocfs2-devel] [PATCH 8/9] ext4: only initialize mmp_bdevname	once
Date: Thu, 14 Jul 2022 10:54:21 -0400	[thread overview]
Message-ID: <YtAuHaiK+Me08swz@mit.edu> (raw)
In-Reply-To: <20220713055317.1888500-9-hch@lst.de>

On Wed, Jul 13, 2022 at 07:53:16AM +0200, Christoph Hellwig wrote:
> mmp_bdevname is currently both initialized nested inside the kthread_run
> call in ext4_multi_mount_protect and in the kmmpd thread started by it.
> 
> Lift the initiaization out of the kthread_run call in
> ext4_multi_mount_protect, move the BUILD_BUG_ON next to it and remove
> the duplicate assignment inside of kmmpd.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Acked-by: Theodore Ts'o <tytso@mit.edu>

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  reply	other threads:[~2022-07-14 14:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  5:53 [Ocfs2-devel] remove bdevname Christoph Hellwig via Ocfs2-devel
2022-07-13  5:53 ` [Ocfs2-devel] [PATCH 1/9] block: stop using bdevname in bdev_write_inode Christoph Hellwig via Ocfs2-devel
2022-07-13  5:53 ` [Ocfs2-devel] [PATCH 3/9] drbd: stop using bdevname in drbd_report_io_error Christoph Hellwig via Ocfs2-devel
2022-07-13  5:53 ` [Ocfs2-devel] [PATCH 5/9] pktcdvd: stop using bdevname in pkt_new_dev Christoph Hellwig via Ocfs2-devel
2022-07-13  5:53 ` [Ocfs2-devel] [PATCH 7/9] ocfs2/cluster: remove the hr_dev_name field from struct o2hb_region Christoph Hellwig via Ocfs2-devel
2022-07-13  5:53 ` [Ocfs2-devel] [PATCH 8/9] ext4: only initialize mmp_bdevname once Christoph Hellwig via Ocfs2-devel
2022-07-14 14:54   ` Theodore Ts'o via Ocfs2-devel [this message]
2022-07-13  7:27 ` [Ocfs2-devel] remove bdevname Johannes Thumshirn via Ocfs2-devel
2022-07-13 15:05 ` Jan Kara via Ocfs2-devel
2022-07-14 16:28 ` Jens Axboe via Ocfs2-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtAuHaiK+Me08swz@mit.edu \
    --to=ocfs2-devel@oss.oracle.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=christoph.boehmwalder@linbit.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=haris.iqbal@ionos.com \
    --cc=hch@lst.de \
    --cc=jack@suse.com \
    --cc=jinpu.wang@ionos.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).