From: Wengang Wang <wen.gang.wang@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH V2] ocfs2: initialize ip_next_orphan
Date: Tue, 10 Nov 2020 16:55:57 -0800 [thread overview]
Message-ID: <a14df5cd-df2c-7a3c-30cd-67e90773ca06@oracle.com> (raw)
In-Reply-To: <20201110130433.a891a2c79e96c0815079a199@linux-foundation.org>
On 11/10/20 1:04 PM, Andrew Morton wrote:
> On Mon, 9 Nov 2020 17:56:41 -0800 Wengang Wang <wen.gang.wang@oracle.com> wrote:
>
>>>> Looking at more on ip_next_orphan, I found it's not initialized when
>>>> allocating a new ocfs2_inode_info structure.
>>>>
>>>> Fix:
>>>> ????initialize ip_next_orphan as NULL.
>>>> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
>>> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
>> Thank you Joseph!
>>
>> AKPM, could you please pull this patch to your tree?
> I'm trying to figure out whether we should add cc:stable to this. But
> to know that, I need to know the end-user visible effects of the bug,
> and that isn't described in this changelog (it should have been!).
>
> Please describe this?
The observed end-user visible effects is that:
The reflink operations from some nodes hang for very long time waiting
for the cluster lock on the orphan directory.
So yes, we should add cc:stable. Sorry, I missed that part.
Thanks,
Wengang
prev parent reply other threads:[~2020-11-11 0:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:17 [Ocfs2-devel] [PATCH V2] ocfs2: initialize ip_next_orphan Wengang Wang
2020-11-10 1:33 ` Joseph Qi
2020-11-10 1:56 ` Wengang Wang
2020-11-10 21:04 ` Andrew Morton
2020-11-11 0:55 ` Wengang Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14df5cd-df2c-7a3c-30cd-67e90773ca06@oracle.com \
--to=wen.gang.wang@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).